Skip to content

Conversation

@rajchiluveru
Copy link
Contributor

@rajchiluveru rajchiluveru commented Nov 21, 2025

SUMMARY
Bump certsuite to v5.5.13

ISSUE TYPE
Bump version

Tests
Test-Hints: TestBos2Workload certsuite-green certsuite-green:ansible_extravars=kbpc_version:v5.5.13

@rajchiluveru rajchiluveru requested a review from a team as a code owner November 21, 2025 16:28
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 21, 2025

📝 Walkthrough

Walkthrough

Bump kbpc_version from v5.5.12 to v5.5.13; remove kbpc_feedback.networking-dpdk-cpu-pinning-exec-probe; add kbpc_feedback.performance-cpu-pinning-no-exec-probes in the role defaults file.

Changes

Cohort / File(s) Change Summary
CertSuite defaults
roles/k8s_best_practices_certsuite/defaults/main.yml
Updated kbpc_version v5.5.12 → v5.5.13; removed kbpc_feedback.networking-dpdk-cpu-pinning-exec-probe; added kbpc_feedback.performance-cpu-pinning-no-exec-probes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • ramperher

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title directly and clearly summarizes the main change: bumping certsuite version to v5.5.13.
Description check ✅ Passed The description is clearly related to the changeset, providing summary and test information for the certsuite version bump.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch cert_5.5.13

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between abca4e2 and f1488b3.

📒 Files selected for processing (1)
  • roles/k8s_best_practices_certsuite/defaults/main.yml (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: dci/check
  • GitHub Check: Ansible-lint Check
  • GitHub Check: Sanity Check (stable-2.9)
  • GitHub Check: Sanity Check (stable-2.18)
🔇 Additional comments (2)
roles/k8s_best_practices_certsuite/defaults/main.yml (2)

3-3: Version bump to v5.5.13 looks good.

The update aligns with the PR objectives and test execution results.


120-120: All verification checks pass—code changes approved.

The new performance-cpu-pinning-no-exec-probes entry integrates cleanly with the feedback configuration and follows the expected naming convention from certsuite v5.5.13. The deprecated networking-dpdk-cpu-pinning-exec-probe entry has been properly removed.

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@softwarefactory-project-zuul
Copy link

@dcibot
Copy link
Collaborator

dcibot commented Nov 21, 2025

Copy link
Contributor

@tonyskapunk tonyskapunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change also needs to adjust what changed in the new release: redhat-best-practices-for-k8s/certsuite#3320

@ramperher
Copy link
Contributor

This change also needs to adjust what changed in the new release: redhat-best-practices-for-k8s/certsuite#3320

+1. In fact I had this change in my pocket list to integrate it once the new certsuite release is delivered. This needs to be included.

@rajchiluveru
Copy link
Contributor Author

This change also needs to adjust what changed in the new release: redhat-best-practices-for-k8s/certsuite#3320

+1. In fact I had this change in my pocket list to integrate it once the new certsuite release is delivered. This needs to be included.

Updated accordingly
https://github.com/dci-labs/bos2-ci-config/pull/595
https://github.com/dci-labs/dallas-pipelines/pull/1480

@ramperher
Copy link
Contributor

This change also needs to adjust what changed in the new release: redhat-best-practices-for-k8s/certsuite#3320

+1. In fact I had this change in my pocket list to integrate it once the new certsuite release is delivered. This needs to be included.

Updated accordingly dci-labs/bos2-ci-config#595 dci-labs/dallas-pipelines#1480

Also, you need to update kbpc_feedback variable in this role to include the renaming.

@softwarefactory-project-zuul
Copy link

Copy link
Contributor

@ramperher ramperher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dcibot
Copy link
Collaborator

dcibot commented Nov 24, 2025

@ramperher ramperher dismissed tonyskapunk’s stale review November 24, 2025 14:22

Changes have been addressed, I'll dismiss the review to be able to merge the change.

@rajchiluveru rajchiluveru added this pull request to the merge queue Nov 24, 2025
Merged via the queue into main with commit ce77f64 Nov 24, 2025
9 checks passed
@rajchiluveru rajchiluveru deleted the cert_5.5.13 branch November 24, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants