Refactoring to change strings into block strings #1133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
datho7561
force-pushed
the
1119-convert-inline-block-strings
branch
from
64a73c4 to
6269b2d
Compare
datho7561
force-pushed
the
1119-convert-inline-block-strings
branch
8 times, most recently
from
479ad4c to
d669f4a
Compare
datho7561
changed the title
Contributor
Author
|
@nyarly if you have time, do you mind trying this out to see if it works well for you? I think it's mostly working, but there might be some edge cases I haven't considered. If you need help getting the project set up, free free to ask about that. |
fbricon
force-pushed
the
1119-convert-inline-block-strings
branch
from
d669f4a to
f2fb641
Compare
Contributor
|
You get as many code action pairs as there are new lines in string literals 
|
Adds two new refactoring actions to turn quoted strings into block strings. eg. if you have the following ```yaml root: "value1\value2" ``` There are two refactoring actions so that it can be turned into ```yaml root: >- value1 value2 ``` or ```yaml root: |- value1 value2 ``` Fixes redhat-developer#1119 Signed-off-by: David Thompson <[email protected]>
datho7561
force-pushed
the
1119-convert-inline-block-strings
branch
from
f2fb641 to
5a8c344
Compare
Contributor
Author
Should be fixed, I wasn't checking against the cursor position/selection range so I was suggesting all potential string conversions in the document. |
|
@datho7561 Let me see about getting this set up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds two refactorings that change inline strings (i.e.
unquoted, single quoted, double quoted) into block strings. One for folded block string and one for literal block string.eg. if you have the following
There are two refactoring actions so that it can be turned into
or
What issues does this PR fix or reference?
Fixes #1119
Is it tested? How?