Skip to content

Conversation

@christoph-jerolimov
Copy link
Member

@christoph-jerolimov christoph-jerolimov commented Dec 11, 2025

This splits the pr.yaml workflow into a version that works (hopefully) for release-1.8 (and older branches)

See build issues of 1.8 backport #3829 and others:

https://github.com/redhat-developer/rhdh/actions/workflows/pr.yaml?query=is%3Afailure

pr-1.8.yaml is the same as pr.yaml but without the install and test python steps.

Copy link
Member

@karthikjeeyar karthikjeeyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@github-actions
Copy link
Contributor

Copy link
Member

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link

openshift-ci bot commented Dec 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karthikjeeyar, nickboldt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 11, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@christoph-jerolimov
Copy link
Member Author

/override sonarqube

@openshift-ci
Copy link

openshift-ci bot commented Dec 11, 2025

@christoph-jerolimov: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • sonarqube

Only the following failed contexts/checkruns were expected:

  • Auto-Approve and Label PRs
  • Build Image
  • Build with Node.js 22
  • SonarCloud Code Analysis
  • Test with Node.js 22
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override sonarqube

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@christoph-jerolimov
Copy link
Member Author

/override SonarCloud Code Analysis

@openshift-ci
Copy link

openshift-ci bot commented Dec 11, 2025

@christoph-jerolimov: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • Analysis
  • Code
  • SonarCloud

Only the following failed contexts/checkruns were expected:

  • Auto-Approve and Label PRs
  • Build Image
  • Build with Node.js 22
  • SonarCloud Code Analysis
  • Test with Node.js 22
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override SonarCloud Code Analysis

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@christoph-jerolimov
Copy link
Member Author

/override "SonarCloud Code Analysis"

@openshift-ci
Copy link

openshift-ci bot commented Dec 11, 2025

@christoph-jerolimov: Overrode contexts on behalf of christoph-jerolimov: SonarCloud Code Analysis

Details

In response to this:

/override "SonarCloud Code Analysis"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-actions
Copy link
Contributor

@openshift-merge-bot openshift-merge-bot bot merged commit d25e0b3 into redhat-developer:main Dec 11, 2025
19 checks passed
@christoph-jerolimov christoph-jerolimov deleted the fix-pr-workflow-1.8 branch December 11, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants