-
Notifications
You must be signed in to change notification settings - Fork 211
chore: fix pr build and test workflow for 1.8 #3833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix pr build and test workflow for 1.8 #3833
Conversation
Signed-off-by: Christoph Jerolimov <[email protected]>
590b271 to
a10c045
Compare
karthikjeeyar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
|
The image is available at: |
nickboldt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: karthikjeeyar, nickboldt The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
|
/override sonarqube |
|
@christoph-jerolimov: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override SonarCloud Code Analysis |
|
@christoph-jerolimov: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override "SonarCloud Code Analysis" |
|
@christoph-jerolimov: Overrode contexts on behalf of christoph-jerolimov: SonarCloud Code Analysis DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
The image is available at: |
d25e0b3
into
redhat-developer:main

This splits the pr.yaml workflow into a version that works (hopefully) for release-1.8 (and older branches)
See build issues of 1.8 backport #3829 and others:
https://github.com/redhat-developer/rhdh/actions/workflows/pr.yaml?query=is%3Afailure
pr-1.8.yaml is the same as pr.yaml but without the install and test python steps.