-
Notifications
You must be signed in to change notification settings - Fork 211
fix(RHIDP-8971): migrate tests to use extensions catalog entities from overlay repo #3754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
9d56412 to
a9b4ef6
Compare
|
/retest |
a9b4ef6 to
9729237
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
9729237 to
2684ad7
Compare
|
/test e2e-ocp-helm |
nickboldt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The approach here is wrong.
We do NOT want to continue to embed the catalog entities in the RHDH image. That was why we moved them into a separate container image.
The ask in https://issues.redhat.com/browse/RHIDP-8971 was to have the tests use the NEW location of the catalog index image, not to re-embed the contents back into the RHDH image.
See also https://issues.redhat.com/browse/RHIDP-9764 and https://issues.redhat.com/browse/RHIDP-9762 where we're adding the ability for the helm and operator to deploy the index image at install time.
2684ad7 to
3c65663
Compare
3c65663 to
6ae51b8
Compare
6ae51b8 to
6f5e5c9
Compare
6f5e5c9 to
b5e8a53
Compare
|
The image is available at: /test e2e-ocp-helm |
b5e8a53 to
45e1721
Compare
|
The image is available at: /test e2e-ocp-helm |
45e1721 to
03032fd
Compare
|
The image is available at: /test e2e-ocp-helm |
| initContainers: | ||
| - name: install-dynamic-plugins | ||
| env: | ||
| # Catalog index image for extracting marketplace catalog entities at runtime | ||
| # Uses the new catalog index image location as per RHIDP-9762/RHIDP-9763 | ||
| # (https://github.com/redhat-developer/rhdh-operator/pull/2000) | ||
| - name: CATALOG_INDEX_IMAGE | ||
| value: "quay.io/rhdh/plugin-catalog-index:1.9" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this change, it is causing below failure during the installation phase.
Pulled: quay.io/rhdh/chart:1.9-122-CI
Digest: sha256:171863e62fc9f6a33b2bfc6ad87ebb29d081d53a2054e155119a606b3ae8df81
Error: 1 error occurred:
* Deployment.apps "rhdh-developer-hub" is invalid: spec.template.spec.initContainers[0].image: Required value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, by default the latest helm chart installation will use this quay.io/rhdh/plugin-catalog-index:1.9 catalog image and if you want to override then you can set it this way in helm chart values.
global:
catalogIndex:
image:
registry: quay.io
repository: rhdh/plugin-catalog-index
tag: "1.9"Rest of the changes in this PR is not required. TBH, if this e2e setup uses latest helm chart that contains the catalog-index changes made by @Fortune-Ndlovu then no configuration changes are required, you have to only enable the skipped extension e2e tests due to missing plugins and it should now pass as there will be plugins available in extensions UI.
03032fd to
177b590
Compare
177b590 to
4456540
Compare
|
The image is available at: /test e2e-ocp-helm |
4456540 to
7e41df1
Compare
|
The image is available at: /test e2e-ocp-helm |
7e41df1 to
adb2e11
Compare
|
The image is available at: /test e2e-ocp-helm |
adb2e11 to
cf467a2
Compare
|
The image is available at: /test e2e-ocp-helm |
cf467a2 to
75f6340
Compare
|
The image is available at: /test e2e-ocp-helm |
75f6340 to
f92b5f9
Compare
|
|
The image is available at: /test e2e-ocp-helm |
|
@sanketpathak: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |



Description
https://issues.redhat.com/browse/RHIDP-8971
Please explain the changes you made here.
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer