Skip to content

Conversation

@sanketpathak
Copy link
Contributor

Description

https://issues.redhat.com/browse/RHIDP-8971

Please explain the changes you made here.

Which issue(s) does this PR fix

  • Fixes #?

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@openshift-ci openshift-ci bot requested review from albarbaro and kadel November 27, 2025 13:56
@sanketpathak sanketpathak changed the title Migrate tests to use extensions catalog entities from overlay repo fix(RHIDP-8971): Migrate tests to use extensions catalog entities from overlay repo Dec 3, 2025
@sanketpathak sanketpathak changed the title fix(RHIDP-8971): Migrate tests to use extensions catalog entities from overlay repo fix(RHIDP-8971): migrate tests to use extensions catalog entities from overlay repo Dec 4, 2025
@sanketpathak sanketpathak force-pushed the migrate-tests-to-use-extensions-catalog-entities-from-overlay-repo branch from 9d56412 to a9b4ef6 Compare December 4, 2025 12:41
@sanketpathak
Copy link
Contributor Author

/retest

@sanketpathak sanketpathak force-pushed the migrate-tests-to-use-extensions-catalog-entities-from-overlay-repo branch from a9b4ef6 to 9729237 Compare December 10, 2025 19:04
@openshift-ci
Copy link

openshift-ci bot commented Dec 10, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign christoph-jerolimov for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sanketpathak sanketpathak force-pushed the migrate-tests-to-use-extensions-catalog-entities-from-overlay-repo branch from 9729237 to 2684ad7 Compare December 11, 2025 14:23
@gustavolira
Copy link
Member

/test e2e-ocp-helm

Copy link
Member

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The approach here is wrong.

We do NOT want to continue to embed the catalog entities in the RHDH image. That was why we moved them into a separate container image.

The ask in https://issues.redhat.com/browse/RHIDP-8971 was to have the tests use the NEW location of the catalog index image, not to re-embed the contents back into the RHDH image.

See also https://issues.redhat.com/browse/RHIDP-9764 and https://issues.redhat.com/browse/RHIDP-9762 where we're adding the ability for the helm and operator to deploy the index image at install time.

@sanketpathak sanketpathak force-pushed the migrate-tests-to-use-extensions-catalog-entities-from-overlay-repo branch from 2684ad7 to 3c65663 Compare December 16, 2025 12:09
@sanketpathak sanketpathak force-pushed the migrate-tests-to-use-extensions-catalog-entities-from-overlay-repo branch from 3c65663 to 6ae51b8 Compare December 16, 2025 15:49
@sanketpathak sanketpathak force-pushed the migrate-tests-to-use-extensions-catalog-entities-from-overlay-repo branch from 6ae51b8 to 6f5e5c9 Compare December 16, 2025 16:01
@sanketpathak sanketpathak force-pushed the migrate-tests-to-use-extensions-catalog-entities-from-overlay-repo branch from 6f5e5c9 to b5e8a53 Compare December 17, 2025 10:57
@github-actions
Copy link
Contributor

The image is available at:

/test e2e-ocp-helm

@sanketpathak sanketpathak force-pushed the migrate-tests-to-use-extensions-catalog-entities-from-overlay-repo branch from b5e8a53 to 45e1721 Compare December 19, 2025 10:54
@github-actions
Copy link
Contributor

The image is available at:

/test e2e-ocp-helm

@sanketpathak sanketpathak force-pushed the migrate-tests-to-use-extensions-catalog-entities-from-overlay-repo branch from 45e1721 to 03032fd Compare December 23, 2025 15:14
@github-actions
Copy link
Contributor

The image is available at:

/test e2e-ocp-helm

Comment on lines 346 to 370
initContainers:
- name: install-dynamic-plugins
env:
# Catalog index image for extracting marketplace catalog entities at runtime
# Uses the new catalog index image location as per RHIDP-9762/RHIDP-9763
# (https://github.com/redhat-developer/rhdh-operator/pull/2000)
- name: CATALOG_INDEX_IMAGE
value: "quay.io/rhdh/plugin-catalog-index:1.9"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this change, it is causing below failure during the installation phase.

Pulled: quay.io/rhdh/chart:1.9-122-CI
Digest: sha256:171863e62fc9f6a33b2bfc6ad87ebb29d081d53a2054e155119a606b3ae8df81
Error: 1 error occurred:
	* Deployment.apps "rhdh-developer-hub" is invalid: spec.template.spec.initContainers[0].image: Required value

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, by default the latest helm chart installation will use this quay.io/rhdh/plugin-catalog-index:1.9 catalog image and if you want to override then you can set it this way in helm chart values.

global:
    catalogIndex:
      image:
        registry: quay.io
        repository: rhdh/plugin-catalog-index
        tag: "1.9"

Rest of the changes in this PR is not required. TBH, if this e2e setup uses latest helm chart that contains the catalog-index changes made by @Fortune-Ndlovu then no configuration changes are required, you have to only enable the skipped extension e2e tests due to missing plugins and it should now pass as there will be plugins available in extensions UI.

@sanketpathak sanketpathak force-pushed the migrate-tests-to-use-extensions-catalog-entities-from-overlay-repo branch from 03032fd to 177b590 Compare December 24, 2025 09:03
@sanketpathak sanketpathak force-pushed the migrate-tests-to-use-extensions-catalog-entities-from-overlay-repo branch from 177b590 to 4456540 Compare December 24, 2025 09:33
@github-actions
Copy link
Contributor

The image is available at:

/test e2e-ocp-helm

@sanketpathak sanketpathak force-pushed the migrate-tests-to-use-extensions-catalog-entities-from-overlay-repo branch from 4456540 to 7e41df1 Compare December 24, 2025 12:07
@github-actions
Copy link
Contributor

The image is available at:

/test e2e-ocp-helm

@sanketpathak sanketpathak force-pushed the migrate-tests-to-use-extensions-catalog-entities-from-overlay-repo branch from 7e41df1 to adb2e11 Compare December 24, 2025 13:26
@github-actions
Copy link
Contributor

The image is available at:

/test e2e-ocp-helm

@sanketpathak sanketpathak force-pushed the migrate-tests-to-use-extensions-catalog-entities-from-overlay-repo branch from adb2e11 to cf467a2 Compare December 26, 2025 10:37
@github-actions
Copy link
Contributor

The image is available at:

/test e2e-ocp-helm

@sanketpathak sanketpathak force-pushed the migrate-tests-to-use-extensions-catalog-entities-from-overlay-repo branch from cf467a2 to 75f6340 Compare December 26, 2025 13:29
@github-actions
Copy link
Contributor

The image is available at:

/test e2e-ocp-helm

@sanketpathak sanketpathak force-pushed the migrate-tests-to-use-extensions-catalog-entities-from-overlay-repo branch from 75f6340 to f92b5f9 Compare December 30, 2025 12:13
@sonarqubecloud
Copy link

@github-actions
Copy link
Contributor

The image is available at:

/test e2e-ocp-helm

@openshift-ci
Copy link

openshift-ci bot commented Dec 30, 2025

@sanketpathak: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ocp-helm f92b5f9 link true /test e2e-ocp-helm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants