Skip to content

Conversation

@Zaperex
Copy link
Member

@Zaperex Zaperex commented Nov 21, 2025

Description

  • Finished migrating the next builds to become hermetic
  • Replaced old upstream Dockerfile with the Konflux Containerfile since it's not longer used
  • Updated documentation on local container builds and migrated a modified downstream localBuild.sh script (requires VPN) to make local hermetic builds easier.
  • Removed instances of the old upstream build process from the github workflows
  • Updated some scripts to point to the new Containerfile location
  • Also refactored the github actions to use environmental variables for better readability, maintainability and security (via input sanitization).

This will require some small modifications to the downstream to accommodate the new Containerfile location.

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Example of a successful test run on my fork (switched registry to my own registry for this run): https://github.com/Zaperex/rhdh/actions/runs/19770877442
Test builds uploaded to https://quay.io/repository/my-test-organization/test-repo

Signed-off-by: Frank Kong <[email protected]>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
Signed-off-by: Frank Kong <[email protected]>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
Signed-off-by: Frank Kong <[email protected]>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
- Rename Dockerfile to Containerfile
- Adds a local hermeto build script for local testing
- Remove obsolete .rhdh directory and merged the doc content with docker

Signed-off-by: Frank Kong <[email protected]>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
…i-arch-hermetic-builds

Signed-off-by: Frank Kong <[email protected]>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
…ile locations

Signed-off-by: Frank Kong <[email protected]>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
Signed-off-by: Frank Kong <[email protected]>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@Zaperex Zaperex force-pushed the add-multi-arch-hermetic-builds branch from da721f0 to 25e4ce1 Compare November 21, 2025 16:34
Signed-off-by: Frank Kong <[email protected]>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
Signed-off-by: Frank Kong <[email protected]>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
Signed-off-by: Frank Kong <[email protected]>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
Signed-off-by: Frank Kong <[email protected]>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

Signed-off-by: Frank Kong <[email protected]>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
…i-arch-hermetic-builds

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@github-actions
Copy link
Contributor

…i-arch-hermetic-builds

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
…i-arch-hermetic-builds

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@github-actions
Copy link
Contributor

Signed-off-by: Frank Kong <[email protected]>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@github-actions
Copy link
Contributor

…i-arch-hermetic-builds

Signed-off-by: Frank Kong <[email protected]>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
Signed-off-by: Frank Kong <[email protected]>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

…i-arch-hermetic-builds

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
Signed-off-by: Frank Kong <[email protected]>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@openshift-ci
Copy link

openshift-ci bot commented Dec 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign christoph-jerolimov for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 5, 2025

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days.

@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants