fix: save document when workspace editor comes from rename files. #1367
+18
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelozerr
force-pushed
the
applyWorkspaceEdit_saveDocument_renameFiles
branch
from
22697aa to
eb8b751
Compare
Contributor
Author
|
It seems this PR breaks CI build https://github.com/redhat-developer/lsp4ij/actions/runs/19424106614/job/55567493292?pr=1367#step:5:542 @sergeysavchuk please test this PR if it fixes your issue and tries to adapt it if you have some trouble. I am busy for now but if you have time to work on this issue it would be very nice. Thanks! |
angelozerr
force-pushed
the
applyWorkspaceEdit_saveDocument_renameFiles
branch
2 times, most recently
from
c1a1f55 to
56fbe5f
Compare
Signed-off-by: azerr <[email protected]>
angelozerr
force-pushed
the
applyWorkspaceEdit_saveDocument_renameFiles
branch
from
56fbe5f to
b933600
Compare
Contributor
Author
|
@sergeysavchuk could you retry the PR. I save the document only with did rename files otherwise CI build fails |
Contributor
Author
|
@sergeysavchuk please retry the PR. If it is working for you, I will merge it |
Contributor
|
@angelozerr I'm going to test it today, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: save document when workspace editor comes from rename files.