Service Registry + Kafka + Quarkus quick start by smccarthy-ie · Pull Request #328 · redhat-developer/app-services-guides

smccarthy-ie · 2021-10-04T16:28:09Z

Add second draft of user instructions for new Service Registry + Kafka + Quarkus quick start

smccarthy-ie · 2021-10-05T11:25:42Z

@bibryam @carlesarnal @wtrocki @EricWittmann

I've cleaned up the instructions for the new quick start so all tests are passing, and incorporated the simplified code changes from #327. Please review for technical accuracy and let me know if you have any updates. Thanks.

quarkus-service-registry/README.adoc

carlesarnal

Most of the content looks good to me but some parts have to be adapted to the new quickstart architecture.

carlesarnal · 2021-10-06T09:51:14Z

@smccarthy-ie let me know if you need more information or anything about the application itself, thanks!

smccarthy-ie · 2021-10-06T15:30:53Z

@bibryam @EricWittmann
I've updated with excellent review feedback from Carles and Wojciech. I think this one is almost ready to merge now. Please let me know if you approve or have further updates. Thanks!

…quarkus is updated

smccarthy-ie · 2021-10-07T10:43:38Z

Received review feedback and approval from Bilgin in Chat, and also clarification from Carles that the OAUTH_SERVER_URL and OAUTH_REALM env vars are required for now until Quarkus is updated (these can both be removed later when the code sample is updated).

quarkus-service-registry/README.adoc

jbyrne-redhat · 2021-10-07T17:21:07Z

Looks great, @smccarthy-ie. Just a few things to consider from me. Mainly small things that will be obvious to most, but not necessarily all. Cheers.

carlesarnal

LGTM now. Thanks, @smccarthy-ie!

* docs: initial version of the guide * fix: restructure tutorial content for better alignment for RHOAS CLI * docs: service registry cli guide Signed-off-by: prmellor <pmellor@redhat.com> * docs: service registry cli guide Signed-off-by: prmellor <pmellor@redhat.com> * fix: remove confusing sentence Co-authored-by: PaulRMellor <47596553+PaulRMellor@users.noreply.github.com> * docs: add abstract to procedures Signed-off-by: prmellor <pmellor@redhat.com> * fix: build issue * docs: service registry instance without defaults Signed-off-by: prmellor <pmellor@redhat.com> * fix: add mixxing version from consumer config * docs: remove angle brackets from example Signed-off-by: prmellor <pmellor@redhat.com> * docs: change keys Signed-off-by: prmellor <pmellor@redhat.com> * fix: another duplicated key * Update rhoas-cli-kafka/README.adoc * Update rhoas-cli-service-registry/README.adoc Co-authored-by: PaulRMellor <47596553+PaulRMellor@users.noreply.github.com> * fix: build issue * docs: review edits BI Signed-off-by: prmellor <pmellor@redhat.com> * docs: review edits WT for name command Signed-off-by: prmellor <pmellor@redhat.com> Co-authored-by: Wojciech Trocki <wtrocki@redhat.com>

Signed-off-by: prmellor <pmellor@redhat.com>

* Add basic metrics section in getting started QS. * SME review from Duncan * Peer tweaks

* docs: fix links in CLI guides Signed-off-by: prmellor <pmellor@redhat.com> * cli command updates Signed-off-by: prmellor <pmellor@redhat.com> * review edits RK Signed-off-by: prmellor <pmellor@redhat.com> * return wget to step Signed-off-by: prmellor <pmellor@redhat.com>

Tested with Kafka 2.8.1 and the correct option is: ``` --consumer.config <String: config file> Consumer config properties file. Note that [consumer-property] takes precedence over this config. ```

* Rethinking metrics approach * Tweak metrics section * John feedback

…er#335)

…-developer#343)

… Service Fleet Manager API Reference (redhat-developer#341)

…per#338)

* fix: add kafka acl commands * fix: add note about cli reference doc * Update rhoas-cli-kafka/README.adoc Co-authored-by: PaulRMellor <47596553+PaulRMellor@users.noreply.github.com> * Update rhoas-cli-kafka/README.adoc Co-authored-by: Ramakrishna Pattnaik <rkpattnaik780@gmail.com> * Update rhoas-cli-kafka/README.adoc Co-authored-by: PaulRMellor <47596553+PaulRMellor@users.noreply.github.com> * Update rhoas-cli-kafka/README.adoc Co-authored-by: PaulRMellor <47596553+PaulRMellor@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: PaulRMellor <47596553+PaulRMellor@users.noreply.github.com> * Update README.adoc * fix: add acl bullet * Update rhoas-cli-kafka/README.adoc Co-authored-by: PaulRMellor <47596553+PaulRMellor@users.noreply.github.com> * Update rhoas-cli-kafka/README.adoc * Update rhoas-cli-kafka/README.adoc Co-authored-by: Ramakrishna Pattnaik <rkpattnaik780@gmail.com> * Update rhoas-cli-kafka/README.adoc * Update rhoas-cli-kafka/README.adoc Co-authored-by: PaulRMellor <47596553+PaulRMellor@users.noreply.github.com> Co-authored-by: Ramakrishna Pattnaik <rkpattnaik780@gmail.com>

smccarthy-ie added 6 commits October 1, 2021 17:30

clean up draft of service registry quarkus quick start from bilgin

f01376e

update section IDs to fix quick start build errors, minor edits

b86a096

add changes to simplify code example in PR 327

16332bd

add final step to view generated schemas

9df0caa

clarify separate consumer and producer processes

0552145

pick up new attributes

1e36c28

smccarthy-ie marked this pull request as draft October 5, 2021 11:10

openshift-ci bot added the do-not-merge/work-in-progress label Oct 5, 2021

wtrocki reviewed Oct 5, 2021

View reviewed changes

quarkus-service-registry/README.adoc Outdated Show resolved Hide resolved

smccarthy-ie requested a review from bibryam October 5, 2021 13:47

carlesarnal reviewed Oct 6, 2021

View reviewed changes

quarkus-service-registry/README.adoc Show resolved Hide resolved

carlesarnal reviewed Oct 6, 2021

View reviewed changes

quarkus-service-registry/README.adoc Outdated Show resolved Hide resolved

carlesarnal reviewed Oct 6, 2021

View reviewed changes

quarkus-service-registry/README.adoc Outdated Show resolved Hide resolved

carlesarnal reviewed Oct 6, 2021

View reviewed changes

quarkus-service-registry/README.adoc Outdated Show resolved Hide resolved

carlesarnal reviewed Oct 6, 2021

View reviewed changes

quarkus-service-registry/README.adoc Outdated Show resolved Hide resolved

carlesarnal reviewed Oct 6, 2021

View reviewed changes

quarkus-service-registry/README.adoc Outdated Show resolved Hide resolved

carlesarnal reviewed Oct 6, 2021

View reviewed changes

quarkus-service-registry/README.adoc Outdated Show resolved Hide resolved

carlesarnal reviewed Oct 6, 2021

View reviewed changes

quarkus-service-registry/README.adoc Outdated Show resolved Hide resolved

carlesarnal requested changes Oct 6, 2021

View reviewed changes

adding technical review feedback from carles and wojciech

2eb34f6

smccarthy-ie requested a review from EricWittmann October 6, 2021 15:35

adding technical review feedback from carles and wojciech

8423316

smccarthy-ie requested a review from jbyrne-redhat October 7, 2021 10:18

add OAUTH_SERVER_URL and OAUTH_REALM env vars required for now until …

4da592e

…quarkus is updated

smccarthy-ie requested a review from rkubis October 7, 2021 11:10

smccarthy-ie marked this pull request as ready for review October 7, 2021 11:14

jbyrne-redhat reviewed Oct 7, 2021

View reviewed changes

quarkus-service-registry/README.adoc Outdated Show resolved Hide resolved

carlesarnal approved these changes Oct 13, 2021

View reviewed changes

smccarthy-ie marked this pull request as draft October 13, 2021 11:34

openshift-ci bot added the do-not-merge/work-in-progress label Oct 13, 2021

add correct SR icon, QE and peer review feedback

3625bbf

smccarthy-ie removed the do-not-merge/work-in-progress label Oct 14, 2021

smccarthy-ie added 2 commits October 14, 2021 16:17

regen attributes for new guides

df91faf

regen attributes for new cli guides

348d851

smccarthy-ie marked this pull request as ready for review October 14, 2021 15:51

carlesarnal and others added 19 commits October 15, 2021 16:36

Simplify registry quickstart (redhat-developer#327)

4cf371c

docs: updated readme with new CLI doc (redhat-developer#329)

7611129

Signed-off-by: prmellor <pmellor@redhat.com>

docs: cli guide mod doc fix (redhat-developer#330)

31e71a4

Signed-off-by: prmellor <pmellor@redhat.com>

Add basic metrics section in getting started QS. (redhat-developer#332)

c8e2673

* Add basic metrics section in getting started QS. * SME review from Duncan * Peer tweaks

Add access mgmt content. (redhat-developer#325)

63144e9

fix: ./kafka-console-consumer.sh cmd line (redhat-developer#337)

7ba4d6a

Tested with Kafka 2.8.1 and the correct option is: ``` --consumer.config <String: config file> Consumer config properties file. Note that [consumer-property] takes precedence over this config. ```

Remove name from service account commands (redhat-developer#336)

e8c32d2

Rethinking metrics approach (redhat-developer#339)

333484a

* Rethinking metrics approach * Tweak metrics section * John feedback

Added missing dash to kafka-console-consumer command. (redhat-develop…

6f88093

…er#335)

Fix the pom.xml files for quarkus-service-registry-quickstart (redhat…

5991565

…-developer#343)

Update the url for Service Registry core REST API Reference and Kafka…

f457e00

… Service Fleet Manager API Reference (redhat-developer#341)

Add placeholder values registry quickstart (redhat-developer#333)

cabfa20

Check installation and version of rhoas CLI on Windows (redhat-develo…

c0147ba

…per#338)

Add missing links to getting started (redhat-developer#347)

8ba41ce

rebase for recently added new guides

5e39469

Merge branch 'main' into sr-kafka-quarkus-qs

79d351d

smccarthy-ie merged commit 67bbfa9 into redhat-developer:main Oct 15, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Service Registry + Kafka + Quarkus quick start#328

Service Registry + Kafka + Quarkus quick start#328
smccarthy-ie merged 31 commits intoredhat-developer:mainfrom
smccarthy-ie:sr-kafka-quarkus-qs

smccarthy-ie commented Oct 4, 2021 •

edited

Loading

Uh oh!

smccarthy-ie commented Oct 5, 2021 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

carlesarnal left a comment

Uh oh!

carlesarnal commented Oct 6, 2021

Uh oh!

smccarthy-ie commented Oct 6, 2021 •

edited

Loading

Uh oh!

smccarthy-ie commented Oct 7, 2021

Uh oh!

Uh oh!

jbyrne-redhat commented Oct 7, 2021

Uh oh!

carlesarnal left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

Conversation

smccarthy-ie commented Oct 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

smccarthy-ie commented Oct 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

carlesarnal left a comment

Choose a reason for hiding this comment

Uh oh!

carlesarnal commented Oct 6, 2021

Uh oh!

smccarthy-ie commented Oct 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

smccarthy-ie commented Oct 7, 2021

Uh oh!

Uh oh!

jbyrne-redhat commented Oct 7, 2021

Uh oh!

carlesarnal left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

smccarthy-ie commented Oct 4, 2021 •

edited

Loading

smccarthy-ie commented Oct 5, 2021 •

edited

Loading

smccarthy-ie commented Oct 6, 2021 •

edited

Loading