Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 9 additions & 18 deletions cmd/rhoas/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,18 +2,13 @@ package main

import (
"context"
"encoding/json"
"fmt"
"os"

"github.com/redhat-developer/app-services-cli/pkg/api/kas"
"github.com/redhat-developer/app-services-cli/pkg/doc"
"github.com/redhat-developer/app-services-cli/pkg/dump"
"github.com/redhat-developer/app-services-cli/pkg/localize"
"github.com/redhat-developer/app-services-cli/pkg/localize/goi18n"

"github.com/redhat-developer/app-services-cli/pkg/cmdutil"

"github.com/redhat-developer/app-services-cli/internal/build"

"github.com/redhat-developer/app-services-cli/internal/config"
Expand Down Expand Up @@ -57,24 +52,16 @@ func main() {
}

err = rootCmd.Execute()
if debug.Enabled() {
build.CheckForUpdate(context.Background(), logger, localizer)
}
if err == nil {
return
}

if e, ok := kas.GetAPIError(err); ok {
logger.Error("Error:", e.GetReason())
if debug.Enabled() {
errJSON, _ := json.Marshal(e)
_ = dump.JSON(cmdFactory.IOStreams.ErrOut, errJSON)
build.CheckForUpdate(context.Background(), logger, localizer)
}
os.Exit(1)
return
}

if err = cmdutil.CheckSurveyError(err); err != nil {
logger.Error("Error:", err)
if err != nil {
Copy link
Collaborator

@wtrocki wtrocki Jul 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This brings patter that our commands should no longer log message when error happens but return error that is exact message of what have happened. +100. Woth to document in contributing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of our commands log the error, they all already return the error and let the main program handle it.

logger.Error(wrapErrorf(err, localizer))
build.CheckForUpdate(context.Background(), logger, localizer)
os.Exit(1)
}
}
Expand Down Expand Up @@ -131,3 +118,7 @@ func initConfig(f *factory.Factory) error {
}
return nil
}

func wrapErrorf(err error, localizer localize.Localizer) error {
return fmt.Errorf("Error: %w. %v", err, localizer.MustLocalize("common.log.error.verboseModeHint"))
}
5 changes: 3 additions & 2 deletions docs/commands/rhoas.adoc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions docs/commands/rhoas_cluster.adoc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions docs/commands/rhoas_cluster_bind.adoc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions docs/commands/rhoas_cluster_connect.adoc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions docs/commands/rhoas_cluster_status.adoc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions docs/commands/rhoas_completion.adoc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions docs/commands/rhoas_completion_bash.adoc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions docs/commands/rhoas_completion_fish.adoc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions docs/commands/rhoas_completion_zsh.adoc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions docs/commands/rhoas_config.adoc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions docs/commands/rhoas_config_dev-preview.adoc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions docs/commands/rhoas_kafka.adoc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions docs/commands/rhoas_kafka_consumer-group.adoc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions docs/commands/rhoas_kafka_consumer-group_delete.adoc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions docs/commands/rhoas_kafka_consumer-group_describe.adoc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions docs/commands/rhoas_kafka_consumer-group_list.adoc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions docs/commands/rhoas_kafka_create.adoc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions docs/commands/rhoas_kafka_delete.adoc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions docs/commands/rhoas_kafka_describe.adoc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions docs/commands/rhoas_kafka_list.adoc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions docs/commands/rhoas_kafka_topic.adoc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions docs/commands/rhoas_kafka_topic_create.adoc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions docs/commands/rhoas_kafka_topic_delete.adoc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions docs/commands/rhoas_kafka_topic_describe.adoc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions docs/commands/rhoas_kafka_topic_list.adoc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions docs/commands/rhoas_kafka_topic_update.adoc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions docs/commands/rhoas_kafka_use.adoc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions docs/commands/rhoas_login.adoc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading