Skip to content

feat(consumer-group list): add search flag #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rkpattnaik780 merged 3 commits into from
Jul 9, 2021
+13 −0
Merged

feat(consumer-group list): add search flag #813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
afda40f
feat(consumer-group list): add search flag
rkpattnaik780 Jul 7, 2021
6ce22de
fix: add validation for search input
rkpattnaik780 Jul 8, 2021
d05b88e
fix: remove validation
rkpattnaik780 Jul 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/commands/rhoas_kafka_consumer-group_list.adoc
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions pkg/cmd/kafka/consumergroup/list/list.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import (
"github.com/redhat-developer/app-services-cli/pkg/cmd/flag"
"github.com/redhat-developer/app-services-cli/pkg/cmdutil"
flagutil "github.com/redhat-developer/app-services-cli/pkg/cmdutil/flags"

"github.com/redhat-developer/app-services-cli/pkg/connection"
"github.com/redhat-developer/app-services-cli/pkg/dump"
"github.com/redhat-developer/app-services-cli/pkg/iostreams"
Expand All @@ -34,6 +35,7 @@ type Options struct {
kafkaID string
limit int32
topic string
search string
}

type consumerGroupRow struct {
Expand Down Expand Up @@ -81,6 +83,7 @@ func NewListConsumerGroupCommand(f *factory.Factory) *cobra.Command {
cmd.Flags().Int32VarP(&opts.limit, "limit", "", 1000, opts.localizer.MustLocalize("kafka.consumerGroup.list.flag.limit"))
cmd.Flags().StringVarP(&opts.output, "output", "o", "", opts.localizer.MustLocalize("kafka.consumerGroup.list.flag.output.description"))
cmd.Flags().StringVar(&opts.topic, "topic", "", opts.localizer.MustLocalize("kafka.consumerGroup.list.flag.topic.description"))
cmd.Flags().StringVar(&opts.search, "search", "", opts.localizer.MustLocalize("kafka.consumerGroup.list.flag.search"))

_ = cmd.RegisterFlagCompletionFunc("topic", func(cmd *cobra.Command, _ []string, toComplete string) ([]string, cobra.ShellCompDirective) {
return cmdutil.FilterValidTopicNameArgs(f, toComplete)
Expand All @@ -91,6 +94,7 @@ func NewListConsumerGroupCommand(f *factory.Factory) *cobra.Command {
return cmd
}

// nolint:funlen
func runList(opts *Options) (err error) {
conn, err := opts.Connection(connection.DefaultConfigRequireMasAuth)
if err != nil {
Expand All @@ -114,6 +118,10 @@ func runList(opts *Options) (err error) {
if opts.topic != "" {
req = req.Topic(opts.topic)
}
if opts.search != "" {
req = req.GroupIdFilter(opts.search)
}

consumerGroupData, httpRes, err := req.Execute()
if err != nil {
if httpRes == nil {
Expand Down
4 changes: 4 additions & 0 deletions pkg/localize/locales/en/cmd/kafka_consumergroup_list.en.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@ $ rhoas kafka consumer-group list -o json
description = 'Description for the --limit flag'
one = 'The maximum number of consumer groups to be returned'

[kafka.consumerGroup.list.flag.search]
description = 'Description for the --search flag'
one = 'Text search to filter consumer groups by ID'

[kafka.consumerGroup.list.log.info.noConsumerGroups]
one = 'Kafka instance "{{.InstanceName}}" has no consumer groups'

Expand Down