Skip to content

fix(kafka delete): show proper message for delete operation #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
craicoverflow merged 2 commits into from
Jun 3, 2021
Merged

fix(kafka delete): show proper message for delete operation #700

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44b83d5
fix(kafka delete): show proper message for delete operation
rkpattnaik780 Jun 3, 2021
b1ec293
fix: change log message
rkpattnaik780 Jun 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions pkg/cmd/kafka/delete/delete.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,9 +126,6 @@ func runDelete(opts *options) error {

kafkaName := response.GetName()

logger.Info(opts.localizer.MustLocalize("kafka.delete.log.info.deleting", localize.NewEntry("Name", kafkaName)))
logger.Info("")

if !opts.force {
promptConfirmName := &survey.Input{
Message: opts.localizer.MustLocalize("kafka.delete.input.confirmName.message"),
Expand Down
6 changes: 1 addition & 5 deletions pkg/localize/locales/en/cmd/kafka_delete.en.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,6 @@ one = 'Unique ID of the Kafka instance you want to delete. If not set, the curre
description = 'Description for the --yes flag'
one = 'Skip confirmation to forcibly delete this Kafka instance.'

[kafka.delete.log.info.deleting]
description = 'Info message when deleting Kafka'
one = 'Deleting Kafka instance "{{.Name}}"'

[kafka.delete.input.confirmName.message]
description = 'Input title for Kafka name confirmation'
one = 'Confirm the name of the instance you want to delete:'
Expand All @@ -51,4 +47,4 @@ one = 'Deleting Kafka instance'

[kafka.delete.log.info.deleteSuccess]
description = 'Info message when instance was deleted'
one = 'Kafka instance "{{.Name}}" has successfully been deleted'
one = 'Kafka instance "{{.Name}}" is being deleted. You can monitor its progress by running "rhoas status".'
Copy link
Contributor

@craicoverflow craicoverflow Jun 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you delete a Kafka instance, it will remove it from the config file, so rhoas status will not show anything. Also, if you delete a Kafka by passing the ID or name, rhoas status will be showing the status of a different one.

Copy link
Contributor

@craicoverflow craicoverflow Jun 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best to remove the second sentence.

Copy link
Contributor

@craicoverflow craicoverflow Jun 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also expect to see the same message when skipping confirmation.

Currently it shows:

❯ rhoas kafka delete -y
Deleting Kafka instance "enda-kafka"

Kafka instance "enda-kafka" has successfully been deleted

Copy link
Contributor Author

@rkpattnaik780 rkpattnaik780 Jun 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated
Screenshot from 2021-06-03 19-50-43