-
Notifications
You must be signed in to change notification settings - Fork 66
fix: add support for creating operator based resource #599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
eacc37e
97e048b
25e6c52
1edf118
00c854e
488f538
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,6 +28,7 @@ type Options struct { | |
| ignoreContext bool | ||
| appName string | ||
| selectedKafka string | ||
| useOperator bool | ||
| } | ||
|
|
||
| func NewBindCommand(f *factory.Factory) *cobra.Command { | ||
|
|
@@ -69,6 +70,7 @@ func NewBindCommand(f *factory.Factory) *cobra.Command { | |
| cmd.Flags().BoolVarP(&opts.forceCreationWithoutAsk, "yes", "y", false, localizer.MustLocalizeFromID("cluster.common.flag.yes.description")) | ||
| cmd.Flags().StringVarP(&opts.namespace, "namespace", "n", "", localizer.MustLocalizeFromID("cluster.common.flag.namespace.description")) | ||
| cmd.Flags().BoolVarP(&opts.ignoreContext, "ignore-context", "", false, localizer.MustLocalizeFromID("cluster.common.flag.ignoreContext.description")) | ||
| cmd.Flags().BoolVarP(&opts.useOperator, "force-operator", "", false, localizer.MustLocalizeFromID("cluster.bind.flag.onlyOperator.description")) | ||
|
||
|
|
||
| return cmd | ||
| } | ||
|
|
@@ -116,7 +118,8 @@ func runBind(opts *Options) error { | |
| err = cluster.ExecuteServiceBinding(logger, *kafkaInstance.Name, | ||
| opts.namespace, | ||
| opts.appName, | ||
| opts.forceCreationWithoutAsk) | ||
| opts.forceCreationWithoutAsk, | ||
| opts.useOperator) | ||
|
|
||
| return err | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have this almost there - moving arguments to structure.