fix(auth): add dual-login to RH-SSO and MAS-SSO#404
Merged
craicoverflow merged 4 commits intomainfrom Mar 5, 2021
Merged
Conversation
craicoverflow
commented
Mar 1, 2021
Collaborator
|
So basically there is a lots of extra changes in this PR but conceptually all is good. We need cleanup not needed stuff add keycloak redirect, require-sso ( that launches micro iframe) Would existing SSO client support localhost redirect? |
craicoverflow
force-pushed
the
double-login
branch
3 times, most recently
from
ff05d5d to
6d4da01
Compare
craicoverflow
changed the title
craicoverflow
force-pushed
the
double-login
branch
from
e3bc329 to
5dc86de
Compare
Contributor
Author
|
Ready for review @wtrocki and @rkpattnaik780 - a large and very important PR. |
added 3 commits
March 4, 2021 16:07
The CLI needs to be logged in to two authorization servers to be able to interact with the control plane and data plane APIs This adds a double-login, meaning the users will log in to both when they run "rhoas login"
craicoverflow
force-pushed
the
double-login
branch
4 times, most recently
from
50cb546 to
e360174
Compare
wtrocki
approved these changes
Mar 4, 2021
craicoverflow
force-pushed
the
double-login
branch
from
e360174 to
0a66f22
Compare
Collaborator
|
Good to merge but after #419 please ;D |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #400
This PR mainly implements dual-login to both RH-SSO and then MAS-SSO. I have also ensured that the entire authorization cycle is updated - logout and token refresh always happen at the same time for both authorization servers.
What has changed
Verification
rhoas login