Skip to content

fix: BootstrapServerHost nil pointer #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
craicoverflow merged 3 commits into from
Jan 22, 2021
Merged

fix: BootstrapServerHost nil pointer #269

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b89589d
fix: BootstrapServerHost nil pointer
wtrocki Jan 22, 2021
8f7c472
chore: reorder to show user what kafka is causing problem
wtrocki Jan 22, 2021
33c9516
fix: simplify value check
Jan 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pkg/cluster/cluster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,11 @@ func ConnectToCluster(connection pkgConnection.Connection,
return
}

if kafkaInstance.BootstrapServerHost == nil || *kafkaInstance.BootstrapServerHost == "" {
Copy link
Contributor

@craicoverflow craicoverflow Jan 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if kafkaInstance.BootstrapServerHost == nil || *kafkaInstance.BootstrapServerHost == "" {
if kafkaInstance.getBootstrapServerHost() == "" {

fmt.Fprintf(os.Stderr, "Kafka instance is missing required BootstrapServerHost variable")
Copy link
Contributor

@craicoverflow craicoverflow Jan 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be using the logger

return
}

fmt.Fprintf(os.Stderr, statusMsg, color.HiGreenString(*kafkaInstance.Name), color.HiGreenString(currentNamespace), color.HiGreenString(secretName))
if shouldContinue := utils.ShowQuestion("Do you want to continue?"); shouldContinue == false {
return
Expand Down