Skip to content

Remove ability to force delete service accounts #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
craicoverflow merged 2 commits into from
Jan 15, 2021
Merged

Remove ability to force delete service accounts #230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c21c986
fix(serviceaccount): remove --force flag
Jan 15, 2021
054775c
docs: update docs
Jan 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion docs/commands/rhoas_serviceaccount_delete.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ $ rhoas serviceaccount delete --id 173c1ad9-932d-4007-ae0f-4da74f4d2ccd
=== Options

....
-f, --force Forcefully delete a service account
-h, --help help for delete
--id string The unique ID of the service account to delete
....
Expand Down
6 changes: 0 additions & 6 deletions pkg/cmd/serviceaccount/delete/delete.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ func NewDeleteCommand(f *factory.Factory) *cobra.Command {
}

cmd.Flags().StringVar(&opts.id, "id", "", "The unique ID of the service account to delete")
cmd.Flags().BoolVarP(&opts.force, "force", "f", false, "Forcefully delete a service account")
_ = cmd.MarkFlagRequired("id")

return cmd
Expand All @@ -54,11 +53,6 @@ func runDelete(opts *Options) (err error) {
return err
}

if opts.force {
logger.Debug("Force deleting service account with ID", opts.id)
return deleteServiceAccount(opts)
}

var confirmDelete bool
promptConfirmDelete := &survey.Confirm{
Message: "Are you sure you want to delete this service account?",
Expand Down