Skip to content

fix: remove redundant refresh token spec #1646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wtrocki merged 1 commit into from
Jul 14, 2022
Merged

fix: remove redundant refresh token spec #1646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions internal/mockutil/mockutil.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import (
"github.com/redhat-developer/app-services-cli/pkg/core/config"
"github.com/redhat-developer/app-services-cli/pkg/core/ioutil/iostreams"
"github.com/redhat-developer/app-services-cli/pkg/core/logging"

"github.com/redhat-developer/app-services-cli/pkg/shared/connection"
"github.com/redhat-developer/app-services-cli/pkg/shared/connection/api"
"github.com/redhat-developer/app-services-cli/pkg/shared/connection/kcconnection"
Expand Down
5 changes: 3 additions & 2 deletions pkg/cmd/cluster/bind/bind.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,15 @@ import (
"github.com/redhat-developer/app-services-cli/pkg/shared/cluster/kubeclient"
"github.com/redhat-developer/app-services-cli/pkg/shared/cluster/v1alpha"
"github.com/redhat-developer/app-services-cli/pkg/shared/connection"

"github.com/redhat-developer/app-services-cli/pkg/shared/factory"
"github.com/redhat-developer/app-services-cli/pkg/shared/servicespec"

"github.com/spf13/cobra"
)

type options struct {
Connection func(connectionCfg *connection.Config) (connection.Connection, error)
Connection func() (connection.Connection, error)
Logger logging.Logger
IO *iostreams.IOStreams
localizer localize.Localizer
Expand Down Expand Up @@ -93,7 +94,7 @@ func NewBindCommand(f *factory.Factory) *cobra.Command {
}

func runBind(opts *options) error {
conn, err := opts.Connection(connection.DefaultConfigSkipMasAuth)
conn, err := opts.Connection()
if err != nil {
return err
}
Expand Down
3 changes: 1 addition & 2 deletions pkg/cmd/cluster/clean/clean.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import (
"github.com/redhat-developer/app-services-cli/pkg/shared/cluster"
"github.com/redhat-developer/app-services-cli/pkg/shared/cluster/kubeclient"
"github.com/redhat-developer/app-services-cli/pkg/shared/cluster/v1alpha"
"github.com/redhat-developer/app-services-cli/pkg/shared/connection"
"github.com/redhat-developer/app-services-cli/pkg/shared/factory"
"github.com/spf13/cobra"

Expand Down Expand Up @@ -59,7 +58,7 @@ func NewCleanCommand(f *factory.Factory) *cobra.Command {
}

func runStatus(opts *options) error {
conn, err := opts.Connection(connection.DefaultConfigSkipMasAuth)
conn, err := opts.Connection()
if err != nil {
return err
}
Expand Down
3 changes: 1 addition & 2 deletions pkg/cmd/cluster/connect/connect.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import (
"github.com/redhat-developer/app-services-cli/pkg/shared/cluster"
"github.com/redhat-developer/app-services-cli/pkg/shared/cluster/kubeclient"
"github.com/redhat-developer/app-services-cli/pkg/shared/cluster/v1alpha"
"github.com/redhat-developer/app-services-cli/pkg/shared/connection"
"github.com/redhat-developer/app-services-cli/pkg/shared/factory"
"github.com/redhat-developer/app-services-cli/pkg/shared/servicespec"

Expand Down Expand Up @@ -73,7 +72,7 @@ func NewConnectCommand(f *factory.Factory) *cobra.Command {
}

func runConnect(opts *options) error {
conn, err := opts.Connection(connection.DefaultConfigSkipMasAuth)
conn, err := opts.Connection()
if err != nil {
return err
}
Expand Down
3 changes: 1 addition & 2 deletions pkg/cmd/cluster/status/status.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import (
"github.com/redhat-developer/app-services-cli/pkg/shared/cluster"
"github.com/redhat-developer/app-services-cli/pkg/shared/cluster/kubeclient"
"github.com/redhat-developer/app-services-cli/pkg/shared/cluster/v1alpha"
"github.com/redhat-developer/app-services-cli/pkg/shared/connection"
"github.com/redhat-developer/app-services-cli/pkg/shared/factory"
"github.com/spf13/cobra"

Expand Down Expand Up @@ -57,7 +56,7 @@ func NewStatusCommand(f *factory.Factory) *cobra.Command {
}

func runStatus(opts *options) error {
conn, err := opts.Connection(connection.DefaultConfigSkipMasAuth)
conn, err := opts.Connection()
if err != nil {
return err
}
Expand Down
3 changes: 1 addition & 2 deletions pkg/cmd/connector/cluster/addon/addon-parameters.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import (
"github.com/redhat-developer/app-services-cli/pkg/cmd/connector/connectorcmdutil"
"github.com/redhat-developer/app-services-cli/pkg/core/cmdutil/flagutil"
"github.com/redhat-developer/app-services-cli/pkg/core/ioutil/dump"
"github.com/redhat-developer/app-services-cli/pkg/shared/connection"
"github.com/redhat-developer/app-services-cli/pkg/shared/factory"
connectormgmtclient "github.com/redhat-developer/app-services-sdk-go/connectormgmt/apiv1/client"

Expand Down Expand Up @@ -55,7 +54,7 @@ func NewParametersCommand(f *factory.Factory) *cobra.Command {

func runList(opts *options) error {
f := opts.f
conn, err := f.Connection(connection.DefaultConfigSkipMasAuth)
conn, err := f.Connection()
if err != nil {
return err
}
Expand Down
3 changes: 2 additions & 1 deletion pkg/cmd/connector/cluster/create/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package create
import (
"github.com/redhat-developer/app-services-cli/pkg/core/cmdutil/flagutil"
"github.com/redhat-developer/app-services-cli/pkg/core/ioutil/dump"

"github.com/redhat-developer/app-services-cli/pkg/shared/connection"
"github.com/redhat-developer/app-services-cli/pkg/shared/factory"
connectormgmtclient "github.com/redhat-developer/app-services-sdk-go/connectormgmt/apiv1/client"
Expand Down Expand Up @@ -52,7 +53,7 @@ func runCreate(opts *options) error {
f := opts.f

var conn connection.Connection
conn, err := f.Connection(connection.DefaultConfigSkipMasAuth)
conn, err := f.Connection()
if err != nil {
return err
}
Expand Down
3 changes: 2 additions & 1 deletion pkg/cmd/connector/cluster/delete/delete.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import (
"github.com/redhat-developer/app-services-cli/pkg/core/cmdutil/flagutil"
"github.com/redhat-developer/app-services-cli/pkg/core/ioutil/icon"
"github.com/redhat-developer/app-services-cli/pkg/core/localize"

"github.com/redhat-developer/app-services-cli/pkg/shared/connection"
"github.com/redhat-developer/app-services-cli/pkg/shared/factory"

Expand Down Expand Up @@ -70,7 +71,7 @@ func runDelete(opts *options) error {
}

var conn connection.Connection
conn, err := f.Connection(connection.DefaultConfigSkipMasAuth)
conn, err := f.Connection()
if err != nil {
return err
}
Expand Down
3 changes: 1 addition & 2 deletions pkg/cmd/connector/cluster/list/list.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import (
"github.com/redhat-developer/app-services-cli/pkg/core/cmdutil"
"github.com/redhat-developer/app-services-cli/pkg/core/cmdutil/flagutil"
"github.com/redhat-developer/app-services-cli/pkg/core/ioutil/dump"
"github.com/redhat-developer/app-services-cli/pkg/shared/connection"
"github.com/redhat-developer/app-services-cli/pkg/shared/factory"

"github.com/spf13/cobra"
Expand Down Expand Up @@ -66,7 +65,7 @@ func NewListCommand(f *factory.Factory) *cobra.Command {

func runList(opts *options) error {
f := opts.f
conn, err := f.Connection(connection.DefaultConfigSkipMasAuth)
conn, err := f.Connection()
if err != nil {
return err
}
Expand Down
3 changes: 2 additions & 1 deletion pkg/cmd/connector/connector_type/list/list.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import (
"github.com/redhat-developer/app-services-cli/pkg/cmd/connector/connectorcmdutil"
"github.com/redhat-developer/app-services-cli/pkg/core/cmdutil/flagutil"
"github.com/redhat-developer/app-services-cli/pkg/core/ioutil/dump"

"github.com/redhat-developer/app-services-cli/pkg/shared/connection"
"github.com/redhat-developer/app-services-cli/pkg/shared/factory"
connectormgmtclient "github.com/redhat-developer/app-services-sdk-go/connectormgmt/apiv1/client"
Expand Down Expand Up @@ -69,7 +70,7 @@ func runUpdateCommand(opts *options) error {
f := opts.f

var conn connection.Connection
conn, err := f.Connection(connection.DefaultConfigSkipMasAuth)
conn, err := f.Connection()
if err != nil {
return err
}
Expand Down
3 changes: 2 additions & 1 deletion pkg/cmd/connector/create/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import (
"github.com/redhat-developer/app-services-cli/pkg/cmd/registry/artifact/util"
"github.com/redhat-developer/app-services-cli/pkg/core/cmdutil/flagutil"
"github.com/redhat-developer/app-services-cli/pkg/core/ioutil/dump"

"github.com/redhat-developer/app-services-cli/pkg/shared/connection"
"github.com/redhat-developer/app-services-cli/pkg/shared/factory"
connectormgmtclient "github.com/redhat-developer/app-services-sdk-go/connectormgmt/apiv1/client"
Expand Down Expand Up @@ -55,7 +56,7 @@ func runCreate(opts *options) error {
f := opts.f

var conn connection.Connection
conn, err := f.Connection(connection.DefaultConfigSkipMasAuth)
conn, err := f.Connection()
if err != nil {
return err
}
Expand Down
3 changes: 2 additions & 1 deletion pkg/cmd/connector/delete/delete.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"github.com/redhat-developer/app-services-cli/pkg/core/cmdutil/flagutil"
"github.com/redhat-developer/app-services-cli/pkg/core/ioutil/icon"
"github.com/redhat-developer/app-services-cli/pkg/core/localize"

"github.com/redhat-developer/app-services-cli/pkg/shared/connection"
"github.com/redhat-developer/app-services-cli/pkg/shared/factory"

Expand Down Expand Up @@ -66,7 +67,7 @@ func runDelete(opts *options) error {
}

var conn connection.Connection
conn, err := f.Connection(connection.DefaultConfigSkipMasAuth)
conn, err := f.Connection()
if err != nil {
return err
}
Expand Down
3 changes: 2 additions & 1 deletion pkg/cmd/connector/describe/describe.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"github.com/redhat-developer/app-services-cli/pkg/cmd/connector/connectorcmdutil"
"github.com/redhat-developer/app-services-cli/pkg/core/cmdutil/flagutil"
"github.com/redhat-developer/app-services-cli/pkg/core/ioutil/dump"

"github.com/redhat-developer/app-services-cli/pkg/shared/connection"
"github.com/redhat-developer/app-services-cli/pkg/shared/factory"

Expand Down Expand Up @@ -51,7 +52,7 @@ func runDescribe(opts *options) error {
f := opts.f

var conn connection.Connection
conn, err := f.Connection(connection.DefaultConfigSkipMasAuth)
conn, err := f.Connection()
if err != nil {
return err
}
Expand Down
3 changes: 1 addition & 2 deletions pkg/cmd/connector/list/list.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import (
"github.com/redhat-developer/app-services-cli/pkg/core/cmdutil"
"github.com/redhat-developer/app-services-cli/pkg/core/cmdutil/flagutil"
"github.com/redhat-developer/app-services-cli/pkg/core/ioutil/dump"
"github.com/redhat-developer/app-services-cli/pkg/shared/connection"
"github.com/redhat-developer/app-services-cli/pkg/shared/factory"

"github.com/spf13/cobra"
Expand Down Expand Up @@ -67,7 +66,7 @@ func NewListCommand(f *factory.Factory) *cobra.Command {

func runList(opts *options) error {
f := opts.f
conn, err := f.Connection(connection.DefaultConfigSkipMasAuth)
conn, err := f.Connection()
if err != nil {
return err
}
Expand Down
3 changes: 1 addition & 2 deletions pkg/cmd/connector/namespace/create/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import (
"github.com/redhat-developer/app-services-cli/pkg/cmd/connector/connectorcmdutil"
"github.com/redhat-developer/app-services-cli/pkg/cmd/kafka/flagutil"
"github.com/redhat-developer/app-services-cli/pkg/core/ioutil/dump"
"github.com/redhat-developer/app-services-cli/pkg/shared/connection"
"github.com/redhat-developer/app-services-cli/pkg/shared/factory"
"github.com/spf13/cobra"

Expand Down Expand Up @@ -55,7 +54,7 @@ func NewCreateCommand(f *factory.Factory) *cobra.Command {
func runCreate(opts *options) error {

f := opts.f
conn, err := f.Connection(connection.DefaultConfigSkipMasAuth)
conn, err := f.Connection()
if err != nil {
return err
}
Expand Down
3 changes: 1 addition & 2 deletions pkg/cmd/connector/namespace/list/list.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import (
"github.com/redhat-developer/app-services-cli/pkg/core/cmdutil"
"github.com/redhat-developer/app-services-cli/pkg/core/cmdutil/flagutil"
"github.com/redhat-developer/app-services-cli/pkg/core/ioutil/dump"
"github.com/redhat-developer/app-services-cli/pkg/shared/connection"
"github.com/redhat-developer/app-services-cli/pkg/shared/factory"

"github.com/spf13/cobra"
Expand Down Expand Up @@ -65,7 +64,7 @@ func NewListCommand(f *factory.Factory) *cobra.Command {

func runList(opts *options) error {
f := opts.f
conn, err := f.Connection(connection.DefaultConfigSkipMasAuth)
conn, err := f.Connection()
if err != nil {
return err
}
Expand Down
3 changes: 2 additions & 1 deletion pkg/cmd/connector/start/start.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"github.com/redhat-developer/app-services-cli/pkg/cmd/connector/connectorcmdutil"
"github.com/redhat-developer/app-services-cli/pkg/core/cmdutil/flagutil"
"github.com/redhat-developer/app-services-cli/pkg/core/ioutil/dump"

"github.com/redhat-developer/app-services-cli/pkg/shared/connection"
"github.com/redhat-developer/app-services-cli/pkg/shared/contextutil"
"github.com/redhat-developer/app-services-cli/pkg/shared/factory"
Expand Down Expand Up @@ -53,7 +54,7 @@ func runUpdateCommand(opts *options) error {
f := opts.f

var conn connection.Connection
conn, err := f.Connection(connection.DefaultConfigSkipMasAuth)
conn, err := f.Connection()
if err != nil {
return err
}
Expand Down
3 changes: 2 additions & 1 deletion pkg/cmd/connector/stop/stop.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"github.com/redhat-developer/app-services-cli/pkg/cmd/connector/connectorcmdutil"
"github.com/redhat-developer/app-services-cli/pkg/core/cmdutil/flagutil"
"github.com/redhat-developer/app-services-cli/pkg/core/ioutil/dump"

"github.com/redhat-developer/app-services-cli/pkg/shared/connection"
"github.com/redhat-developer/app-services-cli/pkg/shared/contextutil"
"github.com/redhat-developer/app-services-cli/pkg/shared/factory"
Expand Down Expand Up @@ -53,7 +54,7 @@ func runUpdateCommand(opts *options) error {
f := opts.f

var conn connection.Connection
conn, err := f.Connection(connection.DefaultConfigSkipMasAuth)
conn, err := f.Connection()
if err != nil {
return err
}
Expand Down
3 changes: 2 additions & 1 deletion pkg/cmd/connector/update/update.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import (
"github.com/redhat-developer/app-services-cli/pkg/cmd/registry/artifact/util"
"github.com/redhat-developer/app-services-cli/pkg/core/cmdutil/flagutil"
"github.com/redhat-developer/app-services-cli/pkg/core/ioutil/dump"

"github.com/redhat-developer/app-services-cli/pkg/shared/connection"
"github.com/redhat-developer/app-services-cli/pkg/shared/factory"
"github.com/spf13/cobra"
Expand Down Expand Up @@ -60,7 +61,7 @@ func runUpdateCommand(opts *options) error {
f := opts.f

var conn connection.Connection
conn, err := f.Connection(connection.DefaultConfigSkipMasAuth)
conn, err := f.Connection()
if err != nil {
return err
}
Expand Down
3 changes: 2 additions & 1 deletion pkg/cmd/connector/use/use.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (

"github.com/redhat-developer/app-services-cli/pkg/core/ioutil/icon"
"github.com/redhat-developer/app-services-cli/pkg/core/localize"

"github.com/redhat-developer/app-services-cli/pkg/shared/connection"
"github.com/redhat-developer/app-services-cli/pkg/shared/connectorutil"
"github.com/redhat-developer/app-services-cli/pkg/shared/contextutil"
Expand Down Expand Up @@ -69,7 +70,7 @@ func runUse(opts *options) error {
return err
}

conn, err := opts.f.Connection(connection.DefaultConfigSkipMasAuth)
conn, err := opts.f.Connection()
if err != nil {
return err
}
Expand Down
5 changes: 2 additions & 3 deletions pkg/cmd/generate/build-configs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import (
"github.com/redhat-developer/app-services-cli/pkg/core/ioutil/icon"
"github.com/redhat-developer/app-services-cli/pkg/core/localize"
"github.com/redhat-developer/app-services-cli/pkg/core/servicecontext"
"github.com/redhat-developer/app-services-cli/pkg/shared/connection"
"github.com/redhat-developer/app-services-cli/pkg/shared/contextutil"
"github.com/redhat-developer/app-services-cli/pkg/shared/factory"

Expand All @@ -27,7 +26,7 @@ type configValues struct {
}

func createServiceAccount(opts *options, shortDescription string) (*kafkamgmtclient.ServiceAccount, error) {
conn, err := opts.Connection(connection.DefaultConfigSkipMasAuth)
conn, err := opts.Connection()
if err != nil {
return nil, err
}
Expand Down Expand Up @@ -100,7 +99,7 @@ func BuildConfiguration(svcConfig *servicecontext.ServiceConfig, opts *options)
opts.localizer.MustLocalize("serviceAccount.create.log.info.createdSuccessfully", localize.NewEntry("ID", serviceAccount.GetId())),
)

conn, err := opts.Connection(connection.DefaultConfigSkipMasAuth)
conn, err := opts.Connection()
if err != nil {
return err
}
Expand Down
3 changes: 1 addition & 2 deletions pkg/cmd/kafka/acl/admin/admin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import (
"github.com/redhat-developer/app-services-cli/pkg/core/localize"
"github.com/redhat-developer/app-services-cli/pkg/core/logging"
"github.com/redhat-developer/app-services-cli/pkg/core/servicecontext"
"github.com/redhat-developer/app-services-cli/pkg/shared/connection"
"github.com/redhat-developer/app-services-cli/pkg/shared/contextutil"
"github.com/redhat-developer/app-services-cli/pkg/shared/factory"
"github.com/spf13/cobra"
Expand Down Expand Up @@ -114,7 +113,7 @@ func NewAdminACLCommand(f *factory.Factory) *cobra.Command {

func runAdmin(opts *options) (err error) {

conn, err := opts.connection(connection.DefaultConfigRequireMasAuth)
conn, err := opts.connection()
if err != nil {
return err
}
Expand Down
3 changes: 1 addition & 2 deletions pkg/cmd/kafka/acl/create/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import (
"github.com/redhat-developer/app-services-cli/pkg/core/ioutil/dump"
"github.com/redhat-developer/app-services-cli/pkg/core/ioutil/spinner"
"github.com/redhat-developer/app-services-cli/pkg/core/localize"
"github.com/redhat-developer/app-services-cli/pkg/shared/connection"
"github.com/redhat-developer/app-services-cli/pkg/shared/contextutil"
"github.com/redhat-developer/app-services-cli/pkg/shared/factory"
kafkainstanceclient "github.com/redhat-developer/app-services-sdk-go/kafkainstance/apiv1internal/client"
Expand Down Expand Up @@ -115,7 +114,7 @@ func NewCreateCommand(f *factory.Factory) *cobra.Command {
func runAdd(instanceID string, opts *aclcmdutil.CrudOptions) error {
ctx := opts.Context

conn, err := opts.Connection(connection.DefaultConfigRequireMasAuth)
conn, err := opts.Connection()
if err != nil {
return err
}
Expand Down
Loading