Closed
Conversation
jackdelahunt
force-pushed
the
produce-command
branch
2 times, most recently
from
dd76b6a to
1118f5d
Compare
jackdelahunt
force-pushed
the
produce-command
branch
from
1118f5d to
8a70cbc
Compare
jackdelahunt
force-pushed
the
produce-command
branch
from
8a70cbc to
5e1f99f
Compare
wtrocki
reviewed
Jun 10, 2022
wtrocki
reviewed
Jun 10, 2022
wtrocki
reviewed
Jun 10, 2022
wtrocki
reviewed
Jun 10, 2022
| Partition: &opts.partition, | ||
| } | ||
|
|
||
| _, _, err = api.RecordsApi.ProduceRecord(opts.Context, opts.topicName).Record(record).Execute() |
Collaborator
There was a problem hiding this comment.
Future question:
What output we want to provide:
- Message to stderr
- Resulted record returned from the API
- Something else?
Contributor
Author
There was a problem hiding this comment.
Message to stderr with the record produced would be nice, something like the output you get when creating a Kafka instance.
One problem that might come up from this is when a value is binary, might give some weird output and break some terminals.
Collaborator
There was a problem hiding this comment.
Yes. Could have table format as well!
Collaborator
|
Looks good so far. |
jackdelahunt
force-pushed
the
produce-command
branch
from
9b09240 to
6b53d60
Compare
Contributor
Author
|
Closing in favour of #1598 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a produce command to a kafka topic to allow the user to produce messages for a topic. Flags like the partition and key are optional. This is useful for debugging purposes and currently you need another thrid-party kafka cli for this feature.
Still not complying with design guidelines yet
Verification Steps
echo text | rhoas kafka topic produce --name=<topic-name>console.redhat.com -> kafka instances -> instance -> topics -> topic-name -> messagesand confirm message is being seen--keyand--partitionand check if message has these correct values setType of change