Skip to content

fix: clarify errors for kafka create #1447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wtrocki merged 1 commit into from
Feb 17, 2022
Merged

fix: clarify errors for kafka create #1447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pkg/cmd/kafka/create/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,8 +217,10 @@ func runCreate(opts *options) error {

if apiErr := kafkamgmtv1errors.GetAPIError(err); apiErr != nil {
switch apiErr.GetCode() {
case kafkamgmtv1errors.ERROR_24:
case kafkamgmtv1errors.ERROR_120:
return opts.localizer.MustLocalizeError("kafka.create.error.oneinstance")
case kafkamgmtv1errors.ERROR_24:
return opts.localizer.MustLocalizeError("kafka.create.error.temporary.unavailable")
case kafkamgmtv1errors.ERROR_36:
return opts.localizer.MustLocalizeError("kafka.create.error.conflictError", localize.NewEntry("Name", payload.Name))
}
Expand Down
5 changes: 4 additions & 1 deletion pkg/core/localize/locales/en/cmd/kafka.en.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,10 @@ one = 'name is required. Run "rhoas kafka create --name my-kafka"'
one = 'Kafka instance "{{.Name}}" already exists'

[kafka.create.error.oneinstance]
one = 'unable to create new Kafka instance. Only one instance is allowed with an eval account'
one = 'maximum number of allowed instances reached. Please review all instances that your user has access to and delete one or more instances before creating a new one.'

[kafka.create.error.temporary.unavailable]
one = 'unable to create new Kafka instance at this time in specified cloud provider and region. Please try again later or choose another region.'

[kafka.create.region.error.invalidRegion]
one = '''
Expand Down