Skip to content

fix: change partition limit for new topic creation #1406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wtrocki merged 2 commits into from
Feb 1, 2022
Merged

fix: change partition limit for new topic creation #1406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6fbebf2
fix: change partition limit
wtrocki Jan 31, 2022
c1f335a
fix: update tests
wtrocki Feb 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/cmd/kafka/topic/topiccmdutil/validators.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ const (
legalNameChars = "^[a-zA-Z0-9._-]+$"
maxNameLength = 249
minPartitions = 1
maxPartitions = 100
maxPartitions = 1000
)

// Validator is a type for validating Kafka topic configuration values
Expand Down
8 changes: 4 additions & 4 deletions pkg/cmd/kafka/topic/topiccmdutil/validators_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,16 +244,16 @@ func TestValidatePartitionsN(t *testing.T) {
wantErr: true,
},
{
name: "Should be valid when equal to max allowed value(100)",
name: "Should be valid when equal to max allowed value(1000)",
args: args{
partitions: "100",
partitions: "1000",
},
wantErr: false,
},
{
name: "Should be invalid when exceeds 100",
name: "Should be invalid when exceeds 1000",
args: args{
partitions: "102",
partitions: "1002",
},
wantErr: true,
},
Expand Down