-
Notifications
You must be signed in to change notification settings - Fork 66
Future Documentation workflow #1352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 12 commits
765b06d
104fbe6
df77378
61eaa9c
f455818
7d18055
5316b09
3de3e9a
b67c76b
a95d97e
ac1998d
6c503b3
02f72dd
7dd7dd5
4e5ae11
a6a2368
0e95f8d
c369909
66cfdc0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -85,12 +85,13 @@ check-docs: generate-docs ## Check whether reference documentation needs to be g | |
|
|
||
| generate-docs: ## Generate command-line reference documentation | ||
| rm -rf ./docs/commands/* | ||
| go run ./cmd/rhoas docs --dir ./docs/commands --file-format adoc | ||
| go run ./cmd/rhoas docs --dir ./docs/commands --file-format md | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Markdown by default - same rules as with adoc (already replaced in the PR).
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. tip: |
||
| .PHONY: generate-docs | ||
|
|
||
| generate-modular-docs: generate-docs ## Generate modular command-line reference documentation | ||
| SRC_DIR=$$(pwd)/docs/commands DEST_DIR=$$(pwd)/dist go run ./cmd/modular-docs | ||
| .PHONY: generate-modular-docs | ||
| generate-downstream-docs: ## Generate command-line reference documentation in adoc format | ||
| rm -rf ./docs/commands/* | ||
| go run ./cmd/rhoas docs --dir ./dist --file-format adoc | ||
|
Comment on lines
+92
to
+93
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why is this removing
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Very good question. I think I need to provide documentation for that in the contributing to make it clear. So the new workflow will split upstream and downstream:
|
||
| .PHONY: generate-downstream-docs | ||
|
|
||
| lint-lang: ## Lint i18n files | ||
| go install github.com/redhat-developer/app-services-go-linter/cmd/app-services-go-linter@latest | ||
|
|
||
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be enabled once approved. We use other trigger for testing