Skip to content

fix(cluster connect): display service account credentials #1237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rkpattnaik780 merged 2 commits into from
Oct 19, 2021
Merged

fix(cluster connect): display service account credentials #1237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9dc0c18
fix(cluster connect): display service account credentials
rkpattnaik780 Oct 19, 2021
1932fb5
fix: remove client secret and indent grant command
rkpattnaik780 Oct 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions pkg/cluster/connect.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,10 @@ func (c *KubernetesClusterAPIImpl) createServiceAccountSecretIfNeeded(namespace
return fmt.Errorf("%v: %w", cliOpts.Localizer.MustLocalize("cluster.kubernetes.serviceaccountsecret.error.createError"), err)
}

cliOpts.Logger.Info(cliOpts.Localizer.MustLocalize("cluster.kubernetes.createSASecret.log.info.createSuccess", localize.NewEntry("Name", createdSecret.Name)))
cliOpts.Logger.Info(cliOpts.Localizer.MustLocalize("cluster.kubernetes.createSASecret.log.info.createSuccess",
localize.NewEntry("Name", createdSecret.Name),
localize.NewEntry("ClientID", serviceAcct.GetClientId()),
))

return nil
}
Expand Down Expand Up @@ -288,7 +291,7 @@ func (api *KubernetesClusterAPIImpl) watchForServiceStatus(

case <-time.After(60 * time.Second):
w.Stop()
return fmt.Errorf(localizer.MustLocalize("cluster.kubernetes.watchForKafkaStatus.error.timeout"))
return fmt.Errorf(localizer.MustLocalize("cluster.kubernetes.watchForResourceStatus.error.timeout", localize.NewEntry("Resource", serviceDetails.Type)))
}
}
}
14 changes: 12 additions & 2 deletions pkg/localize/locales/en/cmd/cluster.en.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ one = '''
Connection Details:

Service Type: {{.ServiceType}}
Service Name: {{.ServiceName}}
Service Name: {{.ServiceName}}
Kubernetes Namespace: {{.Namespace}}
Service Account Secret: {{.ServiceAccountSecretName}}
'''
Expand Down Expand Up @@ -288,7 +288,17 @@ one = 'Access token already exist on the specified namespace'
one = 'Token Secret "{{.Name}}" created successfully'

[cluster.kubernetes.createSASecret.log.info.createSuccess]
one = 'Service Account Secret "{{.Name}}" created successfully'
one = '''
Service Account Secret "{{.Name}}" created successfully

Client ID: {{.ClientID}}

Make a copy of the client ID to store in a safe place. Credentials won't appear again after closing the terminal.

Execute the following command to grant access to the service account using rhoas cli:

$ rhoas kafka acl grant-access --producer --consumer --service-account {{.ClientID}} --topic "*" --group "*"
'''

[cluster.kubernetes.createTokenSecret.log.info.createFailed]
one = 'Creation of the "{{.Name}}" secret failed:'
Expand Down