fix: remove space after prefix from root error#1047
Merged
craicoverflow merged 3 commits intomainfrom Sep 8, 2021
Merged
Conversation
wtrocki
reviewed
Sep 8, 2021
|
|
||
| if !ok { | ||
| opts.Logger.Info(icon.Success(), opts.localizer.MustLocalize("login.log.info.loginSuccessNoUsername")) | ||
| opts.Logger.Info(icon.SuccessPrefix(), opts.localizer.MustLocalize("login.log.info.loginSuccessNoUsername")) |
Collaborator
There was a problem hiding this comment.
Just idea: opts.Logger.Success
Contributor
Author
There was a problem hiding this comment.
Yeah, that might make things nicer actually, though I do like keeping the Logger lean and focused on log-levels only.
Collaborator
There was a problem hiding this comment.
our logger is not logger per se. It is an stderr printer. Having more high-level methods will be good idea for future issue.
Contributor
Author
There was a problem hiding this comment.
Yeah, but the stderr printer is an implementation of a higher-level Logger interface, which could be implemented in different contexts. Though I do not see it being used in ways other than to stderr
craicoverflow
changed the title
wtrocki
approved these changes
Sep 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to the great work done in #1046
Three things are covered here:
Verification Steps
Windows:
$ rhoas kafka topic list Error: not logged in to identity.api.openshift.com.Linux:
$ rhoas kafka topic list ❌ Not logged in to identity.api.openshift.com.Type of change
Checklist