Skip to content

fix: remove trailing slash from url #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
craicoverflow merged 1 commit into from
Dec 1, 2020
Merged

fix: remove trailing slash from url #103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/cmd/login/login.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import (
"net/http"
"net/url"
"os"
"path"

"github.com/bf2fc6cc711aee1a0c2a/cli/pkg/browser"

Expand Down Expand Up @@ -100,7 +101,7 @@ func runLogin(cmd *cobra.Command, _ []string) error {
// real URL:
gatewayURL, ok := urlAliases[args.url]
if !ok {
gatewayURL = args.url
gatewayURL = path.Clean(args.url)
Copy link
Collaborator

@wtrocki wtrocki Dec 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this work in windows?

Copy link
Contributor Author

@craicoverflow craicoverflow Dec 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it is a web URL, I would think the desktop environment does not matter here?

}

var authURL string
Expand Down