feat: rename debug flag to verbose#845
Conversation
ed23da4 to
0525dfa
Compare
BREAKING: The `debug` flag is now `verbose`. There is no longer any shorthand for `version`.
0525dfa to
8883efd
Compare
1a7d818 to
de580c7
Compare
|
|
||
| if err = cmdutil.CheckSurveyError(err); err != nil { | ||
| logger.Error("Error:", err) | ||
| if err != nil { |
There was a problem hiding this comment.
This brings patter that our commands should no longer log message when error happens but return error that is exact message of what have happened. +100. Woth to document in contributing
There was a problem hiding this comment.
None of our commands log the error, they all already return the error and let the main program handle it.
|
@craicoverflow - I have been told that for breaking changes that can affect docs it is important to have jira and ping docs team so they can verify if the missing flag is not affecting them. I have done a quick check on the guides repo and we should be ok so leaving decision for you. |
Okay, I was unaware. I will create a JIRA. |
BREAKING: The
debugflag is nowverbose. There is also no longer any shorthand forversion.Closes #842
Verification Steps
Run
rhoas kafka list -vand it will enable verbose mode.Type of change
Checklist