Skip to content

feat(kafka topic create): add cleanup policy flag#771

Merged
rkpattnaik780 merged 1 commit intomainfrom
cleanup_policy_create
Jul 1, 2021
Merged

feat(kafka topic create): add cleanup policy flag#771
rkpattnaik780 merged 1 commit intomainfrom
cleanup_policy_create

Conversation

@rkpattnaik780
Copy link
Contributor

@rkpattnaik780 rkpattnaik780 commented Jun 30, 2021

User should be able to specify cleanup policy while creating a Kafka topic.

Closes #769

Verification Steps

  1. Create a kafka topic while passing the --cleanup-policy flag.
  2. Create a Kafka topic in interactive mode, it should prompt options for cleanup-policy.

Screenshot from 2021-06-30 22-38-41

Screenshot from 2021-06-30 22-40-11

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation change
  • Other (please specify)

Checklist

  • Documentation added for the feature
  • CI and all relevant tests are passing
  • Code Review completed
  • Verified independently by reviewer

Copy link
Contributor

@craicoverflow craicoverflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍🏻

Question: will this be followed up by the ability to update the cleanup policy?

@rkpattnaik780
Copy link
Contributor Author

Yes it will be. :) There is an issue open for it as well. #772

@rkpattnaik780 rkpattnaik780 merged commit 5973985 into main Jul 1, 2021
@rkpattnaik780 rkpattnaik780 deleted the cleanup_policy_create branch July 1, 2021 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add flag to provide cleanup policy while creating a Kafka topic

2 participants