feat(completion): dynamic completion for suitable flags#702
Merged
rkpattnaik780 merged 2 commits intomainfrom Jun 11, 2021
Merged
feat(completion): dynamic completion for suitable flags#702rkpattnaik780 merged 2 commits intomainfrom
rkpattnaik780 merged 2 commits intomainfrom
Conversation
craicoverflow
previously approved these changes
Jun 8, 2021
pkg/cmdutil/cmdutil.go
Outdated
| validProviders = []string{} | ||
| directive = cobra.ShellCompDirectiveNoSpace | ||
|
|
||
| conn, err := f.Connection(connection.DefaultConfigRequireMasAuth) |
Contributor
There was a problem hiding this comment.
Is there a reason that DefaultConfigRequireMasAuth is needed?
craicoverflow
dismissed
their stale review
Pending response to question about DefaultConfigRequireMasAuth
pkg/cmdutil/cmdutil.go
Outdated
|
|
||
| api := conn.API() | ||
|
|
||
| cloudProviderResponse, _, err := api.Kafka().GetCloudProviders(context.Background()).Execute() |
Contributor
There was a problem hiding this comment.
I think we should start chaining the entire conn like this where possible:
Suggested change
| cloudProviderResponse, _, err := api.Kafka().GetCloudProviders(context.Background()).Execute() | |
| cloudProviderResponse, _, err := conn.API().Kafka().GetCloudProviders(context.Background()).Execute() |
craicoverflow
approved these changes
Jun 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add dynamic flag completion for
--topicofrhoas kafka consumergroup listand--providerforrhoas kafka create.Addresses #591
Verification Steps
rhoas kafka consumergroup list --topic, it should auto-fill according to topics in the instance.rhoas kafka create <instance name> --provider, it should suggest the available providers.Type of change
Checklist