feat(completion): dynamic completion for suitable flags (#702)

Author: rkpattnaik780

pkg/cmd/kafka/consumergroup/list/list.go

@@ -11,6 +11,7 @@ import (
 	"github.com/redhat-developer/app-services-cli/internal/config"
 	"github.com/redhat-developer/app-services-cli/pkg/cmd/factory"
 	"github.com/redhat-developer/app-services-cli/pkg/cmd/flag"
+	"github.com/redhat-developer/app-services-cli/pkg/cmdutil"
 	flagutil "github.com/redhat-developer/app-services-cli/pkg/cmdutil/flags"
 	"github.com/redhat-developer/app-services-cli/pkg/connection"
 	"github.com/redhat-developer/app-services-cli/pkg/dump"
@@ -81,6 +82,10 @@ func NewListConsumerGroupCommand(f *factory.Factory) *cobra.Command {
 	cmd.Flags().StringVarP(&opts.output, "output", "o", "", opts.localizer.MustLocalize("kafka.consumerGroup.list.flag.output.description"))
 	cmd.Flags().StringVar(&opts.topic, "topic", "", opts.localizer.MustLocalize("kafka.consumerGroup.list.flag.topic.description"))
 
+	_ = cmd.RegisterFlagCompletionFunc("topic", func(cmd *cobra.Command, _ []string, toComplete string) ([]string, cobra.ShellCompDirective) {
+		return cmdutil.FilterValidTopicNameArgs(f, toComplete)
+	})
+
 	flagutil.EnableOutputFlagCompletion(cmd)
 
 	return cmd

pkg/cmd/kafka/create/create.go

@@ -112,6 +112,10 @@ func NewCreateCommand(f *factory.Factory) *cobra.Command {
 	cmd.Flags().StringVarP(&opts.outputFormat, "output", "o", "json", opts.localizer.MustLocalize("kafka.common.flag.output.description"))
 	cmd.Flags().BoolVar(&opts.autoUse, "use", true, opts.localizer.MustLocalize("kafka.create.flag.autoUse.description"))
 
+	_ = cmd.RegisterFlagCompletionFunc(flags.FlagProvider, func(cmd *cobra.Command, _ []string, _ string) ([]string, cobra.ShellCompDirective) {
+		return cmdutil.FetchCloudProviders(f)
+	})
+
 	flagutil.EnableOutputFlagCompletion(cmd)
 
 	return cmd

pkg/cmdutil/cmdutil.go

@@ -6,6 +6,7 @@ import (
 	"os"
 
 	"github.com/AlecAivazis/survey/v2/terminal"
+	"github.com/redhat-developer/app-services-cli/pkg/cloudprovider/cloudproviderutil"
 	"github.com/redhat-developer/app-services-cli/pkg/cmd/factory"
 	"github.com/redhat-developer/app-services-cli/pkg/connection"
 	"github.com/spf13/cobra"
@@ -106,7 +107,7 @@ func FilterValidConsumerGroupIDs(f *factory.Factory, toComplete string) (validID
 }
 
 // FilterValidKafkaNames filters Kafkas by name from the API and returns the names
-// This is used in the cobra.ValidArgsFunction for dynamic completion of topic names
+// This is used in the cobra.ValidArgsFunction for dynamic completion of Kafka instance names
 func FilterValidKafkas(f *factory.Factory, toComplete string) (validNames []string, directive cobra.ShellCompDirective) {
 	validNames = []string{}
 	directive = cobra.ShellCompDirectiveNoSpace
@@ -134,3 +135,25 @@ func FilterValidKafkas(f *factory.Factory, toComplete string) (validNames []stri
 
 	return validNames, directive
 }
+
+// FetchCloudProviders returns the list of supported cloud providers for creating a Kafka instance
+// This is used in the cmd.RegisterFlagCompletionFunc for dynamic completion of --provider
+func FetchCloudProviders(f *factory.Factory) (validProviders []string, directive cobra.ShellCompDirective) {
+	validProviders = []string{}
+	directive = cobra.ShellCompDirectiveNoSpace
+
+	conn, err := f.Connection(connection.DefaultConfigSkipMasAuth)
+	if err != nil {
+		return validProviders, directive
+	}
+
+	cloudProviderResponse, _, err := conn.API().Kafka().GetCloudProviders(context.Background()).Execute()
+	if err != nil {
+		return validProviders, directive
+	}
+
+	cloudProviders := cloudProviderResponse.GetItems()
+	validProviders = cloudproviderutil.GetEnabledNames(cloudProviders)
+
+	return validProviders, directive
+}