fix(kafka delete): show proper message for delete operation#700
Merged
craicoverflow merged 2 commits intomainfrom Jun 3, 2021
Merged
fix(kafka delete): show proper message for delete operation#700craicoverflow merged 2 commits intomainfrom
craicoverflow merged 2 commits intomainfrom
Conversation
craicoverflow
suggested changes
Jun 3, 2021
| [kafka.delete.log.info.deleteSuccess] | ||
| description = 'Info message when instance was deleted' | ||
| one = 'Kafka instance "{{.Name}}" has successfully been deleted' No newline at end of file | ||
| one = 'Kafka instance "{{.Name}}" is being deleted. You can monitor its progress by running "rhoas status".' No newline at end of file |
Contributor
There was a problem hiding this comment.
When you delete a Kafka instance, it will remove it from the config file, so rhoas status will not show anything. Also, if you delete a Kafka by passing the ID or name, rhoas status will be showing the status of a different one.
Contributor
There was a problem hiding this comment.
Best to remove the second sentence.
| [kafka.delete.log.info.deleteSuccess] | ||
| description = 'Info message when instance was deleted' | ||
| one = 'Kafka instance "{{.Name}}" has successfully been deleted' No newline at end of file | ||
| one = 'Kafka instance "{{.Name}}" is being deleted. You can monitor its progress by running "rhoas status".' No newline at end of file |
Contributor
There was a problem hiding this comment.
We should also expect to see the same message when skipping confirmation.
Currently it shows:
❯ rhoas kafka delete -y
Deleting Kafka instance "enda-kafka"
Kafka instance "enda-kafka" has successfully been deleted
craicoverflow
approved these changes
Jun 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #615
Verification Steps
go run ./cmd/rhoas kafka delete <instance-name>Type of change
Checklist