fix: replace service account "name" with "short description"#1193
Merged
craicoverflow merged 2 commits intoredhat-developer:mainfrom Oct 11, 2021
Merged
Conversation
craicoverflow
commented
Oct 8, 2021
craicoverflow
force-pushed
the
serviceaccount-changes
branch
from
ee13c67 to
79874bc
Compare
craicoverflow
force-pushed
the
serviceaccount-changes
branch
2 times, most recently
from
3ba3024 to
bb8607c
Compare
craicoverflow
commented
Oct 11, 2021
| @@ -1,3 +1,5 @@ | |||
| // nolint | |||
Contributor
Author
There was a problem hiding this comment.
golangci-lint run cmd/... pkg/... internal/...
pkg/editor/linux.go:1: File is not `gofmt`-ed with `-s` (gofmt)
// +build !windows
make: *** [Makefile:64: lint] Error 1I was suddenly getting this lint error for some reason.
craicoverflow
requested review from
rkpattnaik780 and
wtrocki
and removed request for
wtrocki
craicoverflow
force-pushed
the
serviceaccount-changes
branch
from
bb8607c to
c75a802
Compare
craicoverflow
changed the title
craicoverflow
force-pushed
the
serviceaccount-changes
branch
2 times, most recently
from
61b6f58 to
b031208
Compare
rkpattnaik780
approved these changes
Oct 11, 2021
added 2 commits
October 11, 2021 11:58
BREAKING CHANGE: The service account `long description` field is removed and the `name` has been re-labeled to `short description`
craicoverflow
force-pushed
the
serviceaccount-changes
branch
from
b031208 to
8bb323a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1156
Remove the short description field from service accounts and rename "name" to "short description".
Verification
rhoas service-account createandrhoas service-account reset-credentials, both in interactive and non-interactive modes.Guides PR: redhat-developer/app-services-guides#336