Skip to content

Commit a969d86

Browse files
fix(kafka create): run interactive if no name provided and fix typos (#705)
1 parent ac694d2 commit a969d86

3 files changed

Lines changed: 6 additions & 3 deletions

File tree

pkg/auth/login/login.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -232,7 +232,7 @@ func (a *AuthorizationCodeGrant) openBrowser(authCodeURL string, redirectURL *ur
232232
func (a *AuthorizationCodeGrant) startServer(ctx context.Context, server *http.Server) {
233233
go func() {
234234
if err := server.ListenAndServe(); err == nil {
235-
a.Logger.Error(a.Localizer.MustLocalize("login.log.error.unableToStartServer"), localize.NewEntry("Error", err))
235+
a.Logger.Error(a.Localizer.MustLocalize("login.log.error.unableToStartServer", localize.NewEntry("Error", err)))
236236
}
237237
}()
238238
<-ctx.Done()

pkg/cmd/kafka/consumergroup/list/list.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ func checkForConsumerGroups(count int, opts *Options, kafkaName string) (hasCoun
187187
if opts.topic == "" {
188188
logger.Info(opts.localizer.MustLocalize("kafka.consumerGroup.list.log.info.noConsumerGroups", kafkaNameTmplPair))
189189
} else {
190-
logger.Info(opts.localizer.MustLocalize("kafka.consumerGroup.list.log.info.noConsumerGroupsForTopic"), kafkaNameTmplPair, localize.NewEntry("TopicName", opts.topic))
190+
logger.Info(opts.localizer.MustLocalize("kafka.consumerGroup.list.log.info.noConsumerGroupsForTopic", kafkaNameTmplPair, localize.NewEntry("TopicName", opts.topic)))
191191
}
192192

193193
return false, nil

pkg/cmd/kafka/create/create.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,10 @@ func NewCreateCommand(f *factory.Factory) *cobra.Command {
9191

9292
if !opts.IO.CanPrompt() && opts.name == "" {
9393
return errors.New(opts.localizer.MustLocalize("kafka.create.argument.name.error.requiredWhenNonInteractive"))
94-
} else if opts.name == "" && opts.provider == "" && opts.region == "" {
94+
} else if opts.name == "" {
95+
if opts.provider != "" || opts.region != "" {
96+
return errors.New(opts.localizer.MustLocalize("kafka.create.argument.name.error.requiredWhenNonInteractive"))
97+
}
9598
opts.interactive = true
9699
}
97100

0 commit comments

Comments
 (0)