bump black version#323
Merged
rbs-jacob merged 3 commits intoredballoonsecurity:masterfrom Jun 7, 2023
Merged
Conversation
rbs-jacob
approved these changes
Jun 6, 2023
Member
rbs-jacob
left a comment
rbs-jacob
left a comment
There was a problem hiding this comment.
Pending passing tests, this looks good!
Contributor
|
@Edward-Larson this created an inconsistency - P.S. We should land #218 eventually to make it possible to detect these kinds of issues in CI tests |
whyitfor
pushed a commit
that referenced
this pull request
Sep 29, 2023
1 task
whyitfor
added a commit
that referenced
this pull request
Sep 29, 2023
Co-authored-by: Wyatt <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One sentence summary of this PR (This should go in the CHANGELOG!)
Bump black version to avoid spurious import-time errors with INFO logging level.
Link to Related Issue(s)
With the logging level set to INFO, at import time, black generates some errors about missing cache etc. These are completely inconsequential but do look a bit nasty (error file not found etc.) so could concern/confuse users. The issue in black is documented here:
psf/black#3193
It has been resolved (making these errors show up with DEBUG log level only, which is fine I guess) but we are on an older version which doesn't include these changes.
Please describe the changes in your request.
Anyone you think should look at this, specifically?