RGW: if KEDA HPA is enabled, then don't override the rgw instance count #3572
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sp98 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| existing.ObjectMeta.OwnerReferences = cephObjectStore.ObjectMeta.OwnerReferences | ||
| cephObjectStore.ObjectMeta = existing.ObjectMeta | ||
|
|
||
| if len(scaledObjects.Items) > 0 { |
There was a problem hiding this comment.
This check for len > 0 is not needed. The for loop will implicitly be a no-op if it is empty.
| if len(scaledObjects.Items) > 0 { |
| // createCephObjectStore creates CephObjectStore in the desired state | ||
| func (r *StorageClusterReconciler) createCephObjectStores(cephObjectStores []*cephv1.CephObjectStore, instance *ocsv1.StorageCluster) error { | ||
| scaledObjects := &keda.ScaledObjectList{} | ||
| err := r.Client.List(r.ctx, scaledObjects) |
There was a problem hiding this comment.
Is this a namespaced resource? I wonder if the list can be focused to our namespace.
If KEDA HPA is enabled, then controller should not override the cound of the RGW instances (spec.gateway.instances). This count will be handled by HPA(KEDA) Signed-off-by: Santosh Pillai <[email protected]>
sp98
force-pushed
the
rgw-hpa-changes
branch
from
e4aacec to
5026dfb
Compare
|
@sp98: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
travisn
left a comment
travisn
left a comment
There was a problem hiding this comment.
LGTM, but looks like the unit tests are failing
2 participants
If KEDA HPA is enabled, then controller should not override the cound of the RGW instances (spec.gateway.instances). This count will be handled by HPA(KEDA)
TODO: