Skip to content

DFBUGS-3803: [release-4.19] controllers: add blockpool label to rns #3440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: release-4.19
Choose a base branch
from
Open

DFBUGS-3803: [release-4.19] controllers: add blockpool label to rns #3440

wants to merge 1 commit into from

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Aug 13, 2025

This is an automated cherry-pick of #3434

/assign rewantsoni

@rewantsoni
controllers: add blockpool label to rns
7ca9939 
UI requires us to add the blockpool name label to the rns in order
to display mirroring information in blockpools page

This is initially added to rns created  by the storagerequest
controller but it was missed while creating the rns in the
storageconsumer controller

Signed-off-by: Rewant Soni <[email protected]>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 13, 2025
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 13, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign travisn for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rewantsoni
Copy link
Member

rewantsoni commented Aug 13, 2025 •
edited by openshift-ci bot
Loading

/retitle DFBUGS-3803: [release-4.19] controllers: add blockpool label to rns

@openshift-ci openshift-ci bot changed the title [release-4.19] controllers: add blockpool label to rns DFBUGS-3803: [release-4.19] controllers: add blockpool label to rns Aug 13, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-important jira/valid-reference Indicates that this PR references a valid jira ticket of any type jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting labels Aug 13, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 13, 2025 •
edited by openshift-ci bot
Loading

@openshift-cherrypick-robot: This pull request references [Jira Issue DFBUGS-3803](https://issues.redhat.com//browse/DFBUGS-3803), which is invalid:

  • expected the bug to target the "odf-4.19.1" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

This is an automated cherry-pick of #3434

/assign rewantsoni

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@rewantsoni rewantsoni

Labels

jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting jira/severity-important jira/valid-reference Indicates that this PR references a valid jira ticket of any type

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@openshift-cherrypick-robot @rewantsoni @openshift-ci-robot