Development Environment using Vagrant#309
Open
pietromenna wants to merge 1 commit intorecursecenter:masterfrom
Open
Development Environment using Vagrant#309pietromenna wants to merge 1 commit intorecursecenter:masterfrom
pietromenna wants to merge 1 commit intorecursecenter:masterfrom
Conversation
.gitignore
Outdated
Member
There was a problem hiding this comment.
Should the Vagrantfile be in .gitignore? It's being tracked below.
Member
Author
|
@zachallaun the idea is that if a future contributor would like to change the settings for it's own virtual machine (for example, assign more memory), it should not be reported as a change. This is the reason why I added to .gitignore. But I can remove it from .gitignore if you prefer. |
Member
|
@pietromenna Gotcha. I think it should be tracked because it's something that might reasonably change. e.g. we update the location of the box to be something other than |
Member
Author
|
@zachallaun I changed it to continue being a tracked file. |
pietromenna
force-pushed
the
vagrant-image
branch
from
122fb5b to
7023bb0
Compare
…enter/community-dev)
pietromenna
force-pushed
the
vagrant-image
branch
from
7023bb0 to
0c2ec53
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains instructions hat future contributors shall follow to use the Vagrant image recursecenter/community-dev.
It also contains files which are required for proper setup. It has been tested on my environment.