Skip to content

[V2] add action_result to subscription & trx #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
douglaslise merged 2 commits into from
Aug 8, 2023
Merged

[V2] add action_result to subscription & trx #659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1309b4
add action_result to subscription & trx
fkosouski Aug 1, 2023
3a98d0a
add test to check action_result is present in transaction response
fkosouski Aug 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion recurly/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1663,6 +1663,7 @@ class Subscription(Resource):
'billing_info',
'billing_info_uuid',
'ramp_intervals',
'action_result'
)

sensitive_attributes = ('number', 'verification_value', 'bulk')
Expand Down Expand Up @@ -1916,7 +1917,8 @@ class Transaction(Resource):
'message',
'approval_code',
'payment_method',
'collected_at'
'collected_at',
'action_result'
)
xml_attribute_attributes = ('type',)
sensitive_attributes = ('number', 'verification_value',)
Expand Down
1 change: 1 addition & 0 deletions tests/fixtures/transaction/created.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,4 +83,5 @@ Location: https://api.recurly.com/v2/transactions/123456789012345678901234567890
<decision>DECLINED</decision>
</fraud>
<a name="refund" href="https://api.recurly.com/v2/transactions/123456789012345678901234567890ab" method="delete"/>
<action_result>example</action_result>
</transaction>
1 change: 1 addition & 0 deletions tests/test_resources.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2629,6 +2629,7 @@ def test_transaction(self):
fraud_info = transaction.fraud
self.assertEquals(fraud_info.score, 88)
self.assertEquals(fraud_info.decision, 'DECLINED')
self.assertEquals(transaction.action_result, 'example')

logger.removeHandler(log_handler)

Expand Down