Incorrect behavior of Php4ConstructorRector

[CasEbb]

Bug Report

Subject	Details
Rector version	last dev-main
Installed as	composer dependency

Php4ConstructorRector doesn't work for classes named Pool.

Minimal PHP Code Causing Issue

See https://getrector.com/demo/c767db67-65f2-47d6-876b-9f53711b748f

<?php

class Poll
{
    function Poll() {}
}

class Pool
{
    function Pool() {}
}

class Poool
{
    function Poool() {}
}

Responsible rules

• Php4ConstructorRector

Expected Behavior

-    function Pool() {}
+    function __construct() {}

[TomasVotruba]

Interesting! Could you send a failng text fixture? Should be doable from the demo page

[CasEbb]

<?php

class Poll
{
    public function Poll() {}
}

class Pool
{
    public function Pool() {}
}

?>
-----
<?php

class Poll
{
    public function __construct() {}
}

class Pool
{
    public function __construct() {}
}

?>

[TomasVotruba]

Thanks. I meant in a pull-request to the rule test, so we have it covered.

[CasEbb]

Ah, how stupid, I could have thought of that myself. Here goes! rectorphp/rector-src#6886

[TomasVotruba]

No worries, I should have been more clearer.

Thank you for the PR 🙏

[github-actions]

This issue has been automatically locked because it has been closed for 150 days. Please open a new issue if you have a similar problem.