[DeadCode] Covers scenario where func_get_args used in constructor for RemoveUnusedConstructorParamRector

[peterfox]

Changes

• Adds a new check in ParamAnalyzer to look for the use of func_get_args within a method
• Adds a test fixture for RemoveUnusedConstructorParamRector to skip when func_get_args

Why

I found this issue popping up if func_get_args was used in a constructor. In theory there's also func_get_arg(int position) to consider as well but it's a question of either:

1. refactor the analyzer to consider param position or
2. just outright skip any methods that use func_get_arg() as well

[TomasVotruba]

Nice one, thank you 👍

[samsonasik]

this should can use VariadicFunctionLikeDetector::isVariadic() that cover 3 functions:

• func_get_arg
• func_get_args
• func_num_args

rector-src/rules/DeadCode/NodeManipulator/VariadicFunctionLikeDetector.php

Line 30 in dc677e1

public function isVariadic(FunctionLike $functionLike): bool

[samsonasik]

I created PR for it:

• [DeadCode] Move Param used via variadic functions check to ParamAnalyzer and remove VariadicFunctionLikeDetector #7016

to merge functionality into ParamAnalyzer and remove the VariadicFunctionLikeDetector as double work and cause manually called.

[github-actions]

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.