[Naming] Re-use repetitive DateTimeInterface object type check on services into PropertyNaming service#6926
Merged
samsonasik merged 5 commits intomainfrom May 25, 2025
Merged
[Naming] Re-use repetitive DateTimeInterface object type check on services into PropertyNaming service#6926samsonasik merged 5 commits intomainfrom
samsonasik merged 5 commits intomainfrom
Conversation
samsonasik
changed the title
samsonasik
commented
May 25, 2025
| final class KeepDateTime | ||
| { | ||
| private ?DateTime $timestamp = null; | ||
| private ?\DateTime $timestamp = null; |
Member
Author
There was a problem hiding this comment.
this was invalid fixture, that missing \ suffix as not from use statement, and it inside namespace, so lookup of DateTime under fixture namespace, the extended DateTimeInterface already covered at
$type->isInstanceOf(ClassName::DATE_TIME_INTERFACE)->yes()
Member
Author
|
All checks have passed 🎉 @TomasVotruba I am merging it ;) |
Contributor
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.