[StrContainsRector] also replace multibyte functions fro strpos and strstr#6901
Merged
samsonasik merged 1 commit intorectorphp:mainfrom May 14, 2025
Merged
[StrContainsRector] also replace multibyte functions fro strpos and strstr#6901samsonasik merged 1 commit intorectorphp:mainfrom
samsonasik merged 1 commit intorectorphp:mainfrom
Conversation
Member
|
Let's give it a try, thank you @JohJohan |
Member
|
@JohJohan oh, the code then need to change with new code: rector-src/rules/Php80/Rector/NotIdentical/StrContainsRector.php Lines 103 to 108 in 5814187 I am going to revert this first, ensure no regression... |
Member
Contributor
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.