[dx] log rules registered in both withRules() and sets, keep them once to avoid duplications or invalid use

[TomasVotruba]

No description provided.

[samsonasik]

By this, this config will no longer working:

<?php

use Rector\Config\RectorConfig;
use Rector\TypeDeclaration\Rector\Property\TypedPropertyFromAssignsRector;

return RectorConfig::configure()
    // A. whole set
    ->withPreparedSets(typeDeclarations: true)
    // B. or few rules
    ->withRules([
        TypedPropertyFromAssignsRector::class
    ]);

for default demo page config https://getrector.com/demo

However, when withConfiguredRule() called, it MUST keep working, as override with configurable eg:

<?php

use Rector\Config\RectorConfig;
use Rector\TypeDeclaration\Rector\Property\TypedPropertyFromAssignsRector;

return RectorConfig::configure()
    // A. whole set
    ->withPreparedSets(typeDeclarations: true)
    // B. OVERRIDE RULE
    ->withConfiguredRule(TypedPropertyFromAssignsRector::class, [
        'inline_public' => true,
    ]);

ref https://getrector.com/demo/c74dab61-ff51-47fe-9391-f14bc34fc84a

this also needs test for configurable rule registered multiple times to keep working, eg: multiple config included with configurable rules.

[TomasVotruba]

The first example is mutually exclusive. Either use A, or B. Not together.

For second use case, I think the configured rules are now skipped, as withRules() accepts only non-configured ones, right?

[samsonasik]

No..., withRules() accept configurable rule with default config, so when collect rules, instanceof ConfigurableRectorInterface should be skipped

[TomasVotruba]

I've just tagged a new Rector release https://github.com/rectorphp/rector-src/releases/tag/2.0.10,
so we can test this in the wild separately 👍

Let's ship it :)

[ottsch]

@TomasVotruba I'm getting this warning, although I'm only using sets:

[WARNING] These rules are registered in both sets and "withRules()". Remove them from "withRules()" to avoid
duplications:

       * Rector\Symfony\Twig134\Rector\Return_\SimpleFunctionAndFilterRector   

    ->withPhp74Sets()
    ->withSets([
        SetList::CODING_STYLE,
        SetList::DEAD_CODE,
        SetList::TYPE_DECLARATION,
        SetList::CODE_QUALITY,
        TwigSetList::TWIG_112,
        TwigSetList::TWIG_127,
        TwigSetList::TWIG_134,
        TwigSetList::TWIG_140,
    ])

[samsonasik]

I can reproduce:

                                                                                                                        
 [WARNING] These rules are registered in both sets and "withRules()". Remove them from "withRules()" to avoid           
           duplications:                                                                                                
                                                                                                                        
           * Rector\Symfony\Twig134\Rector\Return_\SimpleFunctionAndFilterRector                                        
                                                                                                                        

 1/1 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

It seems due to RectorConfig::configure()->withRules() there

https://github.com/rectorphp/rector-symfony/blob/3681411a79a40459a9e8beb49bd855878fb5f2a7/config/sets/twig/twig134.php#L8C8-L8C44

that's should not happen as it should uniquely set, it probably due to it re-merged on RectorConfig::configure() called, the way we can do for fast fix this is possibly with change to normal:

-return RectorConfig::configure()->withRules([SimpleFunctionAndFilterRector::class]);
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->rule(SimpleFunctionAndFilterRector::class);
+};

config, but that's seems will cause keep issue on rector extension, as more and more of them may use new syntax of RectorConfig::configure()

[samsonasik]

#6840

[github-actions]

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.