[Transform] Remove ArgumentFuncCallToMethodCallRector as never used #3774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@TomasVotruba it still used by rector-laravel https://github.com/driftingly/rector-laravel/blob/ea3b1da64bbd11146d3e2f3ccefbba1cef59dfd3/config/sets/laravel-static-to-injection.php#L8 /cc @driftingly you need to migrate the code |
Contributor
|
@TomasVotruba just curious, isn't the removal of a rule a BC break? as it may be used by end user configurations I think |
Member
Author
|
@samsonasik I see. In that case should be ported there as better meets Laravel specific needs. @driftingly Could you handle the copy of the rule? |
Member
Author
|
@yguedidi It could be so, that's what we try to find out. |
|
Done in driftingly/rector-laravel#108 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recall I added this rule for Laravel "functions to facades" article many years ago as a demo for Rector features.
In the end its hardly practical and never used in any communityset. Let's see if this assumption is true :)