[Php74] Add ParenthesizeNestedTernaryRector#2859
Merged
TomasVotruba merged 12 commits intomainfrom Aug 31, 2022
Merged
Conversation
Member
Author
|
implemented 🎉 /cc @fruitl00p |
samsonasik
force-pushed
the
add-parenthesize-nested-ternary
branch
2 times, most recently
from
b8258f1 to
8992f47
Compare
Member
Author
|
All checks have passed 🎉 @TomasVotruba it is ready for review. |
samsonasik
force-pushed
the
add-parenthesize-nested-ternary
branch
from
d30f347 to
44f4b8a
Compare
Member
Author
|
rebased and regenerate docs |
Member
Author
|
@TomasVotruba tests error seems related with removal of which cause error: There were 8 errors:
1) Error
The data provider specified for Rector\Tests\Naming\Naming\UseImportsResolver\UseImportsResolverTest::testUsesFromProperty is invalid.
Error: Class "Symplify\EasyTesting\DataProvider\StaticFixtureFinder" not found
/home/runner/work/rector-src/rector-src/rules-tests/Naming/Naming/UseImportsResolver/UseImportsResolverTest.php:64 |
Member
|
Thank you 👍 ,I'm merging the PR as tests are in another PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#7432