Merge multiple Dockerfiles into a single one #2167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
SimonYansenZhao
requested review from
anargyri,
gramhagen,
loomlike,
miguelgfierro and
wutaomsft
as code owners
Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
anargyri
reviewed
Sep 16, 2024
Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
Collaborator
|
hi @SimonYansenZhao the tests should be working now after #2169 |
Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
miguelgfierro
approved these changes
Nov 13, 2024
Collaborator
miguelgfierro
left a comment
miguelgfierro
left a comment
There was a problem hiding this comment.
Looks great.
Fixed some minor typos
Co-authored-by: Miguel Fierro <3491412+miguelgfierro@users.noreply.github.com>
Co-authored-by: Miguel Fierro <3491412+miguelgfierro@users.noreply.github.com>
Co-authored-by: Miguel Fierro <3491412+miguelgfierro@users.noreply.github.com>
Co-authored-by: Miguel Fierro <3491412+miguelgfierro@users.noreply.github.com>
Co-authored-by: Miguel Fierro <3491412+miguelgfierro@users.noreply.github.com>
Co-authored-by: Miguel Fierro <3491412+miguelgfierro@users.noreply.github.com>
Co-authored-by: Miguel Fierro <3491412+miguelgfierro@users.noreply.github.com>
Co-authored-by: Miguel Fierro <3491412+miguelgfierro@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR merges the following multiple uses of Dockerfile into a single place in
tools/docker/Dockerfilefor easier maintainance in the future:Related Issues
None
References
Checklist:
git commit -s -m "your commit message".staging branchAND NOT TOmain branch.