Revert and fix python evaluation#2119
Merged
miguelgfierro merged 2 commits intostagingfrom Jun 26, 2024
Merged
Conversation
This reverts commit b73ee01.
It turns out I ran incorrect tests and the evaluation module was not really working
daviddavo
requested review from
SimonYansenZhao,
anargyri,
gramhagen,
loomlike,
miguelgfierro and
wutaomsft
as code owners
miguelgfierro
approved these changes
Jun 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On #2114 I ran a search and replace, and then ran the tests, which were passing in my machine. It turns out I was not running the tests on the new code, but on another one. I reverted that commit and made the modifications manually when necessary, removing the warnings and making sure that all tests were passing.
Related Issues
References
Checklist:
git commit -s -m "your commit message".staging branchAND NOT TOmain branch.