Fix breaking change in sklearn in log_loss #2106

Merged

miguelgfierro merged 1 commit intostagingfrom

bug/log_loss_breaking_change

Jun 5, 2024

Collaborator

miguelgfierro commented Jun 3, 2024 •

edited

Loading

Description

Sklearn removed eps parameter in log_loss.

See 0.5.0 https://github.com/scikit-learn/scikit-learn/blob/abbaed326c8f0e4a8083979701f01ce581612713/sklearn/metrics/_classification.py#L2829C30-L2829C31

vs
0.4.2: https://github.com/scikit-learn/scikit-learn/blob/8721245511de2f225ff5f9aa5f5fadce663cd4a3/sklearn/metrics/_classification.py#L2822

Related Issues

References

Checklist:

I have followed the contribution guidelines and code style for this project.
I have added tests covering my contributions.
I have updated the documentation accordingly.
I have signed the commits, e.g. git commit -s -m "your commit message".
This PR is being made to staging branch AND NOT TO main branch.


          breaking change in sklearn in log_loss 💥💥

a92b31a

Signed-off-by: miguelgfierro <[email protected]>

miguelgfierro requested review from SimonYansenZhao, anargyri, gramhagen, loomlike and wutaomsft as code owners

June 3, 2024 15:01

anargyri approved these changes

View reviewed changes

miguelgfierro merged commit 058300d into staging

miguelgfierro deleted the bug/log_loss_breaking_change branch

June 5, 2024 04:59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

anargyri anargyri approved these changes

gramhagen Awaiting requested review from gramhagen gramhagen is a code owner

loomlike Awaiting requested review from loomlike loomlike is a code owner

wutaomsft Awaiting requested review from wutaomsft

SimonYansenZhao Awaiting requested review from SimonYansenZhao SimonYansenZhao is a code owner

Labels

None yet