Conversation
Signed-off-by: miguelgfierro <[email protected]>
miguelgfierro
requested review from
SimonYansenZhao,
anargyri,
gramhagen,
loomlike and
wutaomsft
as code owners
Signed-off-by: miguelgfierro <[email protected]>
Signed-off-by: miguelgfierro <[email protected]>
Signed-off-by: miguelgfierro <[email protected]>
Signed-off-by: miguelgfierro <[email protected]>
|
We still have some references to Microsoft in the text we should review in another PR e.g. https://github.com/recommenders-team/recommenders/blob/bug/new_tests/SECURITY.md#:~:text=Security-,Microsoft,-takes%20the%20security |
|
Also in setup.py the Microsoft references need to be fixed. |
|
I guess also contributing license is not relevant any more and should be replaced with something from LF. |
Signed-off-by: miguelgfierro <[email protected]>
Signed-off-by: miguelgfierro <[email protected]>
Signed-off-by: miguelgfierro <[email protected]>
|
I updated your comments @anargyri. I´m not sure about the new email given by the LF, I´ve tried to write them to see how it works. |
|
|
||
| </details> | ||
|
|
||
| ## Microsoft Contributor License Agreement |
There was a problem hiding this comment.
@ibrahimhaddad Does LF require some similar type of agreement for contributors?
| }, | ||
| author="RecoDev Team at Microsoft", | ||
| author="Recommenders contributors", | ||
| author_email="[email protected]", |
There was a problem hiding this comment.
I have sent an email to Ibrahim to see which one we can add
| @@ -1,35 +0,0 @@ | |||
| <!-- BEGIN MICROSOFT SECURITY.MD V0.0.1 BLOCK --> | |||
There was a problem hiding this comment.
Also @ibrahimhaddad do we need to include anything about LF security policy?
can you create an issue for that to track? or did you already created one? |
|
|
||
| @pytest.mark.notebooks | ||
| @pytest.mark.experimental | ||
| @pytest.mark.skip(reason="xLearn pip package has installation incompatibilities") |
There was a problem hiding this comment.
is this temporal? or do we want to skip only at some condition, like using skipif("some_module" not in sys.modules, reason="'some_module' was not installed correctly maybe due to version conflict")?
There was a problem hiding this comment.
In reality, it is a matter than someone has time to integrate xlearn in the core libraries
loomlike
left a comment
loomlike
left a comment
There was a problem hiding this comment.
Thanks. I left a comment regarding skipping a test for your reference.
Signed-off-by: miguelgfierro <[email protected]>
Tracked here: #1997 |
3 participants
Description
Related Issues
Failed run: https://github.com/recommenders-team/recommenders/actions/runs/6239152244
References
Checklist:
staging branchand not tomain branch.