Simplify eval args #1828
Merged
Simplify eval args #1828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Staging to main: optimizations splitters, NDCG, and update tests
AdityaSoni19031997
requested review from
anargyri,
gramhagen,
loomlike,
miguelgfierro and
wutaomsft
as code owners
Collaborator
miguelgfierro
left a comment
miguelgfierro
left a comment
There was a problem hiding this comment.
I think this is really good. I just added some format suggestions
Contributor
Author
|
Yay! Its merged! Any other issue that's on priority? |
Collaborator
|
hey @AdityaSoni19031997, it's great that you are contributing. Some ideas for you, from easier to harder:
Apart from this, feel free to select an issue on the repo and work on this. The only thing I would advice is that if you select one issue, let me know first to make sure it is not something that is already fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The changes has been made to simplify the arguments required for the evaluation of @k metrics. It was found that
col_ratingcolumn wasn't used by the these methods, hence the function signature could be simplified for better user experience.Pytest Results
>>>pytest tests/unit/recommenders/evaluation/test_python_evaluation.py platform darwin -- Python 3.8.14, pytest-7.1.3, pluggy-1.0.0 rootdir: /Users/asoni9/Desktop/recommenders plugins: hypothesis-6.56.2, mock-3.10.0, rerunfailures-10.2, cov-4.0.0 collected 30 items tests/unit/recommenders/evaluation/test_python_evaluation.py .............................. ==== 30 passed, 8 warnings in 0.84s ====Related Issues
#1737
References
Not Applicable
Checklist:
staging branchand not tomain branch.