Support PRs from forked repos#1747
Merged
pradnyeshjoshi merged 3 commits intostagingfrom Jun 15, 2022
Merged
Conversation
miguelgfierro
approved these changes
Jun 15, 2022
Collaborator
miguelgfierro
left a comment
There was a problem hiding this comment.
@pradnyeshjoshi @simonzhaoms great job guys for finding a fix for this
Collaborator
|
@pradnyeshjoshi another question, do you need this PR to be in main to take effect? let me know and we can do a PR in that case |
Collaborator
Author
@miguelgfierro once we merge it into staging, people can make PRs into staging from their forks. Since we only make PRs to staging, no immediate need to release to main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Triggering execution of unit tests on AzureML requires access to credentials, which are not accessible from a forked repository, causing unit tests triggered by the PRs from outside collaborators to fail with a login error. This PR addresses the issue by using
pull_request_targettrigger, which allows execution of workflows in the context of a base repository, thus granting access to the AzureML credentials.Here is a sample PR from a forked repo that can now successfully trigger AzureML tests #1746
Related Issues
Checklist:
staging branchand not tomain branch.