Skip to content

Conversation

@miguelgfierro
Copy link
Collaborator

Description

Related Issues

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov-commenter
Copy link

Codecov Report

Merging #1708 (badcc58) into staging (4106333) will increase coverage by 23.33%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           staging    #1708       +/-   ##
============================================
+ Coverage     0.00%   23.33%   +23.33%     
============================================
  Files           87       87               
  Lines         9132     9132               
============================================
+ Hits             0     2131     +2131     
- Misses           0     7001     +7001     
Flag Coverage Δ
nightly ?
pr-gate 23.33% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
recommenders/datasets/mind.py 0.00% <0.00%> (ø)
recommenders/datasets/movielens.py 66.37% <0.00%> (+66.37%) ⬆️
recommenders/datasets/download_utils.py 90.00% <0.00%> (+90.00%) ⬆️
recommenders/evaluation/spark_evaluation.py 87.11% <0.00%> (+87.11%) ⬆️
recommenders/models/newsrec/io/mind_iterator.py 0.00% <0.00%> (ø)
recommenders/models/newsrec/models/base_model.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4106333...badcc58. Read the comment docs.

@miguelgfierro
Copy link
Collaborator Author

Thanks @simonzhaoms

@miguelgfierro miguelgfierro merged commit 3d1d7a4 into staging Apr 29, 2022
@miguelgfierro miguelgfierro deleted the miguelgfierro-patch-1 branch April 29, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants