Remove casting of user and item IDs in Spark evaluation#1686
Merged
Remove casting of user and item IDs in Spark evaluation#1686
Conversation
Codecov Report
@@ Coverage Diff @@
## staging #1686 +/- ##
===========================================
+ Coverage 23.08% 23.10% +0.02%
===========================================
Files 88 87 -1
Lines 9120 9110 -10
===========================================
Hits 2105 2105
Misses 7005 7005
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
User and item IDs should not be cast into double (if they are strings then this turns them into null values).
Related Issues
Checklist:
staging branchand not tomain branch.