Skip to content

SAR+ docstring patch #1648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
simonzhaoms merged 2 commits into from
Feb 17, 2022
Merged

SAR+ docstring patch #1648

simonzhaoms merged 2 commits into from
Feb 17, 2022

Conversation

@simonzhaoms
Copy link
Collaborator

@simonzhaoms simonzhaoms commented Feb 17, 2022

Description

Add type info in docstring for the parameters of SARPlus.recommend_k_items() suggested by @miguelgfierro here

Related Issues

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@simonzhaoms simonzhaoms changed the title Simonz/sarplus docstring patch SAR+ docstring patch Feb 17, 2022
miguelgfierro
miguelgfierro approved these changes Feb 17, 2022
View reviewed changes
Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonzhaoms simonzhaoms merged commit 4639087 into staging Feb 17, 2022
@simonzhaoms simonzhaoms deleted the simonz/sarplus-docstring-patch branch February 17, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miguelgfierro miguelgfierro miguelgfierro approved these changes

@gramhagen gramhagen Awaiting requested review from gramhagen gramhagen is a code owner

@anargyri anargyri Awaiting requested review from anargyri anargyri is a code owner

@loomlike loomlike Awaiting requested review from loomlike loomlike is a code owner

@wutaomsft wutaomsft Awaiting requested review from wutaomsft

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@simonzhaoms @miguelgfierro